Skip to content

Commit

Permalink
Merge pull request #5369 from ueberdosis/develop
Browse files Browse the repository at this point in the history
  • Loading branch information
nperez0111 authored Jul 24, 2024
2 parents b5c1b32 + 341b01d commit 8337e53
Show file tree
Hide file tree
Showing 192 changed files with 7,265 additions and 2,899 deletions.
5 changes: 5 additions & 0 deletions .changeset/eleven-needles-argue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tiptap/core": patch
---

Adjust the `splitBlock` command to return `false` when it was unsuccessful.
5 changes: 5 additions & 0 deletions .changeset/hungry-jokes-wash.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tiptap/extension-table": patch
---

Set correct `min-width` for a table fixes #5217
5 changes: 5 additions & 0 deletions .changeset/lovely-cougars-care.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tiptap/core": patch
---

This fixes a bug with the placeholder extension where a heading level other than the default was not considered empty, when comparing node contents, we need to consider that the node attributes are carried over for a fair comparison of content instead of attribute values
5 changes: 5 additions & 0 deletions .changeset/shy-otters-tap.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tiptap/extension-link": patch
---

Links were opening twive when the editor was not editable and openOnclick was true, now openOnClick setting will check if it is editable before trying to open programmatically resolves #4877
5 changes: 5 additions & 0 deletions .changeset/silly-socks-work.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tiptap/extension-code-block": patch
---

code-block: on arrow down move into the next node
5 changes: 5 additions & 0 deletions .changeset/sixty-gifts-dream.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tiptap/core": patch
---

Add a check beforecreateNodeViews so that view.setProps is not called when the view has already been destroyed
1 change: 1 addition & 0 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ jobs:
id: changesets
uses: changesets/action@v1
with:
createGithubReleases: false
publish: npm run publish
title: ${{ github.ref_name == 'main' && 'Publish a new stable version' || 'Publish a new pre-release version' }}
commit: >-
Expand Down
1 change: 1 addition & 0 deletions demos/src/Marks/Link/React/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import React, { useCallback } from 'react'

export default () => {
const editor = useEditor({
editable: true,
extensions: [
Document,
Paragraph,
Expand Down
4 changes: 2 additions & 2 deletions demos/src/Nodes/Table/React/index.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ context('/src/Nodes/Table/React/', () => {
const html = editor.getHTML()

expect(html).to.equal(
'<table style="minWidth: 25px"><colgroup><col></colgroup><tbody><tr><td colspan="1" rowspan="1"><p></p></td></tr></tbody></table>',
'<table style="min-width: 25px"><colgroup><col></colgroup><tbody><tr><td colspan="1" rowspan="1"><p></p></td></tr></tbody></table>',
)
})
})
Expand All @@ -75,7 +75,7 @@ context('/src/Nodes/Table/React/', () => {
const html = editor.getHTML()

expect(html).to.equal(
'<table style="minWidth: 25px"><colgroup><col></colgroup><tbody><tr><th colspan="1" rowspan="1"><p></p></th></tr></tbody></table>',
'<table style="min-width: 25px"><colgroup><col></colgroup><tbody><tr><th colspan="1" rowspan="1"><p></p></th></tr></tbody></table>',
)
})
})
Expand Down
4 changes: 2 additions & 2 deletions demos/src/Nodes/Table/Vue/index.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ context('/src/Nodes/Table/Vue/', () => {

const html = editor.getHTML()

expect(html).to.equal('<table style="minWidth: 25px"><colgroup><col></colgroup><tbody><tr><td colspan="1" rowspan="1"><p></p></td></tr></tbody></table>')
expect(html).to.equal('<table style="min-width: 25px"><colgroup><col></colgroup><tbody><tr><td colspan="1" rowspan="1"><p></p></td></tr></tbody></table>')
})
})

Expand All @@ -72,7 +72,7 @@ context('/src/Nodes/Table/Vue/', () => {

const html = editor.getHTML()

expect(html).to.equal('<table style="minWidth: 25px"><colgroup><col></colgroup><tbody><tr><th colspan="1" rowspan="1"><p></p></th></tr></tbody></table>')
expect(html).to.equal('<table style="min-width: 25px"><colgroup><col></colgroup><tbody><tr><th colspan="1" rowspan="1"><p></p></th></tr></tbody></table>')
})
})

Expand Down
Loading

0 comments on commit 8337e53

Please sign in to comment.