lowlight is declared both as a dependency and peerDependency in released code-block-lowlight extension

[enriquecastl]

What’s the bug you are facing?

The lowlight dependency of the @tiptap/code-block-lowlight extension is declared as a dependency and peerDependency simultaneously in the latest release: https://unpkg.com/browse/@tiptap/extension-code-block-lowlight@2.0.0-beta.72/package.json.

This problem is not present in the package.json that exists in the master branch: https://github.com/ueberdosis/tiptap/blob/main/packages/extension-code-block-lowlight/package.json#L25. This leads me to believe that package.json file is modified when the code-block-lowlight extension is released.

Which browser was this experienced in? Are any special extensions installed?

This problem is experienced at build time in our application. The yarn check command fails because the lowlight dependency is declared twice in the package.json file: https://gitlab.com/gitlab-org/gitlab/-/jobs/2619015236

How can we reproduce the bug on our side?

Create a test application that uses the @tiptap/code-block-lowlight extension and run yarn check. The command should fails because of the problem described above.

Can you provide a CodeSandbox?

No response

What did you expect to happen?

The lowlight dependency should be a peerDependency and not a dependency

Anything to add? (optional)

No response

Did you update your dependencies?

• Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

• Yes, I’m a sponsor. 💖

[bdbch]

Hey I'm taking a look at this issue right now.

It seems weird. The only place I can find version ^1.2.0 being pinned as that is in the demos package.json which also results in this dependency being added to the package-lock.json. I'm investigating now if this is the cause of this dependency being added when running lerna publish and if so how we can stop this from happening.

[enriquecastl]

@bdbch: I discovered today that this problem only occurs in the 2.0.0-beta.72 version of the package. If I use the 2.0.0-beta.71 version, the problem is not there:

Perhaps, something changed between those two releases.

https://unpkg.com/browse/@tiptap/extension-code-block-lowlight@2.0.0-beta.71/package.json

[github-actions]

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days