-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to new versions of prosemirror packages #2854
Conversation
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Because of this upgrade, the tables package is broken for now. I'll see if I can find a fix - otherwise will revert the tables package back to a version that still works. |
🔥 |
"prosemirror-model": "^1.16.1", | ||
"prosemirror-state": "^1.3.4", | ||
"prosemirror-view": "^1.23.6" | ||
"lowlight": "^1.20.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bdbch!
I’m trying to upgrade tiptap packages in our application, and I noticed that in the latest released version of code-block-lowlight
declares the lowlight
package as a dependency and a peerDependency: https://unpkg.com/browse/@tiptap/extension-code-block-lowlight@2.0.0-beta.72/package.json
This is not the case in the master branch: https://github.com/ueberdosis/tiptap/blob/main/packages/extension-code-block-lowlight/package.json#L25.
What I find confusing is that part of the changes that I submitted in the PR that moves lowlight to a peerDependency are also included in the latest released version, which differs from what exists in the master branch.
Why is the package.json file different in the master branch and the released package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats weird, could you bring this up in an issue so we can track it? I'd like to look into where this dependency is coming from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any advance here? |
Upgrade your dependencies. |
This is already merged @rootlinux2 the problem you described is coming from the prosemirror-tables package. I'll fork it and work on it to make it work with cjs / require syntax. |
@bdbch, @Amursky but I'm still facing this error!
|
Hey @rootlinux2 we'll publish a new release ASAP. I'll let you know. |
* refactor: upgrade prosemirror packages to new typescript versions * refactor: migrate to new typings from prosemirror * style: fix linting issues * style: fix linting issues * style: fix linting issues * fix(ci): fix build process by reimplement filterTransaction * fix(extension-test): fix broken build because of wrong output file names * fix: fix prosemirror-tables not being bundled correctly for ES6 * fix: move to prosemirror-tables-contently until es6 build is working * fix: fix tests for youtube * fix: fix youtube test * fix(demos): fix demos build
Since Prosemirror switched to Typescript in their new version Tiptap was broken on a fresh install because of a non-fixed version requiring a workaround via overrides. See this issue: #2836
In this PR I'm working on a fix for that to migrate to the new prosemirror versions by default.