Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextSelection warning with Horitzontal Rule #3003

Closed
2 tasks done
jakedolan opened this issue Jul 19, 2022 · 6 comments · Fixed by #4319
Closed
2 tasks done

TextSelection warning with Horitzontal Rule #3003

jakedolan opened this issue Jul 19, 2022 · 6 comments · Fixed by #4319
Labels
Info: Stale The issue or pullrequest has not been updated in a while and might be stale Type: Bug The issue or pullrequest is related to a bug

Comments

@jakedolan
Copy link
Contributor

jakedolan commented Jul 19, 2022

What’s the bug you are facing?

There is a console warning when executing the command setHorizontalRule().

Related to #2846 but not resolved by the fix in @tiptap/core 2.0.0-beta.182.

Which browser was this experienced in? Are any special extensions installed?

Tested in Chrome, Firefox, Opera. Reproducible in minimal install with STR below.

How can we reproduce the bug on our side?

  1. See linked codesandbox.
  2. Click 'Add HR' button.
  3. See warning in console.

Can you provide a CodeSandbox?

https://codesandbox.io/s/priceless-tdd-34begx

What did you expect to happen?

No warning is displayed.

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@jakedolan jakedolan added the Type: Bug The issue or pullrequest is related to a bug label Jul 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Info: Stale The issue or pullrequest has not been updated in a while and might be stale label Feb 7, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 15, 2023
@Pareder
Copy link

Pareder commented Apr 27, 2023

This issue is still reproduced, who can take a look?

@Nantris
Copy link
Contributor

Nantris commented May 21, 2023

This should not be closed. Simply calling editor.commands.setHorizontalRule() produces this warning and results in an invalid selection.

@bdbch could we get this re-opened?

@sjdemartini
Copy link
Contributor

Bump, this should be reopened @bdbch

@bdbch bdbch reopened this Jun 27, 2023
@bdbch bdbch added this to Tiptap Aug 4, 2023
@bdbch bdbch moved this to Triage open in Tiptap Aug 4, 2023
@bdbch bdbch moved this from Triage open to Backlog in Tiptap Aug 5, 2023
@bdbch
Copy link
Member

bdbch commented Aug 5, 2023

Added to the backlog

@bdbch
Copy link
Member

bdbch commented Aug 11, 2023

Fix is in PR (#4319) - will release in the next RC version later this day.

@bdbch bdbch moved this from In Progress to Ready to Merge in Tiptap Aug 11, 2023
@bdbch bdbch moved this from Ready to Merge to Ready for Review in Tiptap Aug 11, 2023
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Tiptap Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Info: Stale The issue or pullrequest has not been updated in a while and might be stale Type: Bug The issue or pullrequest is related to a bug
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants