HorizontalRule: fix setHorizontalRule putting cursor at non-text positions #4319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdbch
added
Type: Bug
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 tasks
|
@bdbch I'm finding that this change isn't working that well: firefox_mjKS0cpkoG.mp4I'm also having a strange issue in your Typist editor: firefox_gLIsARPgGI.mp4For some reason, it's trying to insert an hashtag suggestion. This could either be a problem on our side, or a related issue to the bug above. For now - and even before upgrading tiptap to v2.1 - we've been using a custom horizontal rule extension, with this patch, that seems to work much better. Would be nice to remove this work around from our side, but unfortunately, this behaviour is still buggy on tiptap. |
This was referenced Aug 17, 2023
|
@rfgamaral just to be sure: this got fixed for you with 2.1.6, did it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
This PR fixes an issue with the
setHorizontalRulefunction placing the selection at non-text positions (for exampledoc) after inserting a HorizontalRule node.How did you accomplish your changes
I modified the insert positions of the functions and added a small part of code to determine the next text-node which the cursor can be placed in.
How have you tested your changes
Locally with the HorizontalRule demo.
How can we verify your changes
See above
Remarks
Nothing
Checklist
Related issues
fixes #3003