Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: @tiptap/extension-text-style won't install in starter-kit #5691

Closed
1 task done
ydfzgyj opened this issue Oct 1, 2024 · 4 comments
Closed
1 task done

[Bug]: @tiptap/extension-text-style won't install in starter-kit #5691

ydfzgyj opened this issue Oct 1, 2024 · 4 comments
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug

Comments

@ydfzgyj
Copy link

ydfzgyj commented Oct 1, 2024

Affected Packages

starter-kit

Version(s)

2.8.0

Bug Description

@tiptap/extension-text-style had been added to @tiptap/extension-bullet-list and @tiptap/extension-ordered-list as peerDependencies, so it should also be added to dependencies of @tiptap/starter-kit

Browser Used

Chrome

Code Example URL

No response

Expected Behavior

add @tiptap/extension-text-style to dependencies of @tiptap/starter-kit

Additional Context (Optional)

No response

Dependency Updates

  • Yes, I've updated all my dependencies.
@ydfzgyj ydfzgyj added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug labels Oct 1, 2024
@nperez0111
Copy link
Contributor

Yea this is correct. Would accept a PR to fix it

@Korywon
Copy link

Korywon commented Oct 2, 2024

Temporary workaround is to include @tiptap/extension-text-style as a dependency in our app. Not great, but it works for now.

nperez0111 added a commit that referenced this issue Oct 2, 2024
@nperez0111
fix: add extension-text-style as a dep of @tiptap/starter-kit #5691
ba0b4b2
@nperez0111 nperez0111 mentioned this issue Oct 2, 2024
Merged
5 tasks
nperez0111 added a commit that referenced this issue Oct 2, 2024
@nperez0111
fix: add extension-text-style as a dep of @tiptap/starter-kit #5691 (#…
087e581 
…5693)
@nperez0111 nperez0111 pinned this issue Oct 8, 2024
@nperez0111 nperez0111 unpinned this issue Oct 8, 2024
@HappyNTH HappyNTH mentioned this issue Oct 9, 2024
Closed
@nperez0111
Copy link
Contributor

Dupe of #5707

@nperez0111
Copy link
Contributor

This is released with v2.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ydfzgyj @nperez0111 @Korywon