-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/delete content when drop on another editor #3429
Feature/delete content when drop on another editor #3429
Conversation
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Working on solving the failed checks |
Great !!! Need you now. @bdbch |
2.0 is release, Has this feature been included? |
Not yet. I'll see that we get it into the new release candidate for 2.1.0 soon. Should be coming in the next 2 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review:
The className is not correct now (in The latest version of the Tiptap), now is "tiptap ProseMirror".
Please change it before Merge, Or use if (event.target.parentElement?.classList.contains('ProseMirror')){}
And use if (event.target.parentElement
here can not work in nested items, just work in one level paragraph. @LuchoCateura
For Example:
when I drag a part of paragraph in Editor1, to a paragraph in Editor2, it's work.
when I drag a part of paragraph in Editor1, to a Unordered list item or table cell in Editor2, it's not work.
By the way, really need this feature. Hope it can be released as soon as possible.
I tried a new plan. Please check this pull request and help test it. @bdbch @LuchoCateura iShot_2023-08-14_00.48.28.mp4 |
Closing this as #5893 implemented this fix. |
Now it works for Firefox too