Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/delete content when drop on another editor #3429

Conversation

LuchoCateura
Copy link
Contributor

Now it works for Firefox too

@netlify
Copy link

netlify bot commented Nov 18, 2022

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit a1fbeca
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/637b750e9ba9640009f8b481
😎 Deploy Preview https://deploy-preview-3429--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@LuchoCateura
Copy link
Contributor Author

Working on solving the failed checks

@songispm
Copy link
Contributor

Great !!!

Need you now. @bdbch

@bdbch bdbch added Status: Review Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. labels Mar 29, 2023
@songispm
Copy link
Contributor

2.0 is release, Has this feature been included?

@bdbch
Copy link
Member

bdbch commented Mar 30, 2023

Not yet. I'll see that we get it into the new release candidate for 2.1.0 soon. Should be coming in the next 2 days.

@bdbch bdbch added this to the 2.1.0 Release milestone Mar 30, 2023
Copy link
Contributor

@songispm songispm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review:

image

The className is not correct now (in The latest version of the Tiptap), now is "tiptap ProseMirror".

Please change it before Merge, Or use if (event.target.parentElement?.classList.contains('ProseMirror')){}

And use if (event.target.parentElement here can not work in nested items, just work in one level paragraph. @LuchoCateura
For Example:
when I drag a part of paragraph in Editor1, to a paragraph in Editor2, it's work.
when I drag a part of paragraph in Editor1, to a Unordered list item or table cell in Editor2, it's not work.

By the way, really need this feature. Hope it can be released as soon as possible.

@bdbch @LuchoCateura

@songispm
Copy link
Contributor

I tried a new plan. Please check this pull request and help test it. @bdbch @LuchoCateura

#4328

iShot_2023-08-14_00.48.28.mp4

@bdbch
Copy link
Member

bdbch commented Dec 2, 2024

Closing this as #5893 implemented this fix.

@bdbch bdbch closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants