-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(extension-link): fix link not being kept when pasting url with link #3975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
svenadlung
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was testing some cases. Worked out well for me. Good work 🙌
2 tasks
This was referenced Aug 18, 2023
2 tasks
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
This PR fixes an issue where for example a link gets copied from another richtext (for example Google Docs). When the copied text is a URL (for example
https://github.com/
) but this URL text is already a link (for examplehttps://github.com/ == LINKS TO ==> https://github.com/my/repo
) the link gets dismissed and the text gets pasted as a URL.How did you accomplish your changes
I removed the default pasteHandler as the paste handler will always trigger before any custom logic. The paster handler itself also doesn't know about any marks of the pasted content but only the content text so it wasn't possible to handle the check if a pasted content is already a link in there.
I moved the logic into it's own plugin that will handle said behavior.
How have you tested your changes
I created a Google Docs file with two lines. The document looked like this:
When copying the first line, the pasted content was:
When copying the second line, the pasted content was:
How can we verify your changes
Clone and checkout this branch, then create a demo (or use the existing Marks/Link demo) and paste in content as I described above.
Remarks
Nothing to remark here
Checklist
Related issues