fix(extension/link) Fix wrong URLs applied when pasting more than one #4587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue where posting more than one URLs in the same paste event causes all URLs to link to the first URL in the paste event. I have not yet validated the side effects of the change to other consumers of markPastRule (bold, code, highlight, italic, and strike), nor have written any tests yet
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bdbch
previously approved these changes
Nov 7, 2023
C-Hess
changed the title
nperez0111
force-pushed
the
develop
branch
2 times, most recently
from
bcaef5c to
7e7ae19
Compare
Closed
2 tasks
|
Hey @C-Hess - could you verify if this is still relevant? I'll close this PR for now, feel free to reopen if you think this is still a relevant fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
Fixed an issue where posting more than one URLs in the same paste event causes all URLs to link to the first URL in the paste event.
How have you tested your changes
Created unit tests. Verified other link tests were succeeded. Some were failing but they seem unrelated to my changes
How can we verify your changes
Verify there are no unknown side effects with other mark pasting rules
Checklist
Related issues
#4541