fix: apply #5147 fix to marks and nodes #5156

nperez0111 · 2024-05-15T15:54:48Z

Changes Overview

As a follow up to #5147
In my previous PR, @634750802 reminded me that Nodes & Marks both have the configure method as well and have almost the exact same logic as extensions. So I applied the change to Nodes & Marks as well

Implementation Approach

See $5147

Testing Done

Ran all tests, everything looks good

Verification Steps

See above

Additional Notes

Checklist

I have renamed my PR according to the naming conventions. (e.g. feat: Implement new feature or chore(deps): Update dependencies)
My changes do not break the library.
I have added tests where applicable.
I have followed the project guidelines.
I have fixed any lint issues.

Related Issues

netlify · 2024-05-15T15:55:03Z

✅ Deploy Preview for tiptap-embed ready!

Name	Link
🔨 Latest commit	`dee3946`
🔍 Latest deploy log	https://app.netlify.com/sites/tiptap-embed/deploys/66711d635eec5f00086e81d5
😎 Deploy Preview	https://deploy-preview-5156--tiptap-embed.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nperez0111 · 2024-05-24T08:35:53Z

demos/src/Examples/CodeBlockLanguage/React/index.jsx

+          // addProseMirrorPlugins() {
+          //   console.log('custom', this, this.parent)
+          //   return [
+          //     ...this.parent(),
+          //   ]
+          // },
        })
-        .configure({ lowlight }),
+        .configure({ lowlight })
+        .extend({
+          addProseMirrorPlugins() {
+            return [
+              ...this.parent(),
+            ]
+          },
+        }),


I will need to add more tests for this. Just wanted it out of my mind

packages/core/src/ExtensionManager.ts

packages/core/src/Mark.ts

packages/core/src/Node.ts

nperez0111 · 2024-05-24T08:43:38Z

packages/core/src/Extension.ts

+    const extension = this.extend({
+      addOptions() {
+        return mergeDeep(this.parent?.() || {}, options) as Options
+      },
+    })


This is the secret sauce, a configure is just a short way of expressing additional options to be applied

packages/core/src/Node.ts

packages/core/src/helpers/getSchemaByResolvedExtensions.ts

nperez0111 requested a review from bdbch as a code owner May 15, 2024 15:54

nperez0111 requested a review from bdbch May 15, 2024 15:54

nperez0111 requested a review from svenadlung as a code owner May 15, 2024 15:54

nperez0111 requested a review from svenadlung May 15, 2024 15:54