Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip the order of useEditorState's overloads #5325

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

alii
Copy link
Contributor

@alii alii commented Jul 10, 2024

So that TypeScript will resolve the non-nullable one first, unless the editor is nullable, in which case the other one will resolve.

Related to discussion in #5161 @nperez0111

So that TypeScript will resolve the non-nullable one first, unless the editor is nullable, in which case the other one will resolve.
@alii alii requested review from bdbch and svenadlung as code owners July 10, 2024 16:12
Copy link

changeset-bot bot commented Jul 10, 2024

⚠️ No Changeset found

Latest commit: d42aeff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit d42aeff
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/668eb2e8b6878100084fe1a9
😎 Deploy Preview https://deploy-preview-5325--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@Looskie Looskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah now I get you, sorry we were talking different hooks earlier

@nperez0111 nperez0111 merged commit e902c12 into ueberdosis:develop Jul 11, 2024
4 checks passed
@alii
Copy link
Contributor Author

alii commented Jul 11, 2024

Awesome thank you! Would it be possible to get a beta release with these changes? I realised I didn't make a changeset, apologies.

@nperez0111
Copy link

Ah yea, the changeset was why it didn't release. I'll get a version out for it

@nperez0111
Copy link

Releasing now. Should be available in a couple of minutes

@alii
Copy link
Contributor Author

alii commented Jul 11, 2024

Got it! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants