-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flip the order of useEditorState's overloads #5325
Conversation
So that TypeScript will resolve the non-nullable one first, unless the editor is nullable, in which case the other one will resolve.
|
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah now I get you, sorry we were talking different hooks earlier
Awesome thank you! Would it be possible to get a beta release with these changes? I realised I didn't make a changeset, apologies. |
Ah yea, the changeset was why it didn't release. I'll get a version out for it |
Releasing now. Should be available in a couple of minutes |
Got it! Thank you :) |
So that TypeScript will resolve the non-nullable one first, unless the editor is nullable, in which case the other one will resolve.
Related to discussion in #5161 @nperez0111