Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix shiki setup #5347

Merged
merged 1 commit into from
Jul 15, 2024
Merged

fix: fix shiki setup #5347

merged 1 commit into from
Jul 15, 2024

Conversation

bdbch
Copy link
Member

@bdbch bdbch commented Jul 15, 2024

Changes Overview

This PR fixes an issue with Tiptap Demos not rendering correctly anymore.

Implementation Approach

I upgraded shiki and made sure to output our workers as ES modules.

Testing Done

I've build the demos locally and checked them out by serving the app via vite.

Verification Steps

See above

Additional Notes

Nothing

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@bdbch bdbch requested a review from svenadlung as a code owner July 15, 2024 11:48
Copy link

changeset-bot bot commented Jul 15, 2024

⚠️ No Changeset found

Latest commit: 73fa134

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 73fa134
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/66950c8f74f6cd00088409a8
😎 Deploy Preview https://deploy-preview-5347--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me just settle all the package lock stuff rn and then we can merge

@bdbch bdbch merged commit 7c9516a into develop Jul 15, 2024
14 checks passed
@bdbch bdbch deleted the bugfix/fix-shiki branch July 15, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants