-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update prosemirror-view & prosemirror-tables to most recent version #5385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8bf5be9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 54 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Looking into the typescript issues |
nperez0111
approved these changes
Jul 24, 2024
bdbch
added a commit
that referenced
this pull request
Jul 24, 2024
…5385) * upgrade prosemirror packages to latest versions * added changeset * update package-lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
Updated prosemirror-views & prosemirror-tables to most recent version
Implementation Approach
Actually I was looking for the prosemirror-model update because there was an XSS issue with version 1.22.0 and below (see https://discuss.prosemirror.net/t/heads-up-xss-risk-in-domserializer/6572) - but it seems we already updated it.
While we're at it why not just bump the other prosemirror versions too.
Testing Done
I ran the tests locally + went through the demos manually to see if any functionality is broken (specially tables).
Verification Steps
See above
Checklist