Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prosemirror-view & prosemirror-tables to most recent version #5385

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

bdbch
Copy link
Member

@bdbch bdbch commented Jul 24, 2024

Changes Overview

Updated prosemirror-views & prosemirror-tables to most recent version

Implementation Approach

Actually I was looking for the prosemirror-model update because there was an XSS issue with version 1.22.0 and below (see https://discuss.prosemirror.net/t/heads-up-xss-risk-in-domserializer/6572) - but it seems we already updated it.

While we're at it why not just bump the other prosemirror versions too.

Testing Done

I ran the tests locally + went through the demos manually to see if any functionality is broken (specially tables).

Verification Steps

See above

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

@bdbch bdbch requested a review from nperez0111 July 24, 2024 05:13
@bdbch bdbch self-assigned this Jul 24, 2024
@bdbch bdbch requested a review from svenadlung as a code owner July 24, 2024 05:13
Copy link

changeset-bot bot commented Jul 24, 2024

🦋 Changeset detected

Latest commit: 8bf5be9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages
Name Type
@tiptap/pm Patch
@tiptap/core Patch
@tiptap/extension-blockquote Patch
@tiptap/extension-bold Patch
@tiptap/extension-bubble-menu Patch
@tiptap/extension-bullet-list Patch
@tiptap/extension-character-count Patch
@tiptap/extension-code-block-lowlight Patch
@tiptap/extension-code-block Patch
@tiptap/extension-code Patch
@tiptap/extension-collaboration-cursor Patch
@tiptap/extension-collaboration Patch
@tiptap/extension-color Patch
@tiptap/extension-document Patch
@tiptap/extension-dropcursor Patch
@tiptap/extension-floating-menu Patch
@tiptap/extension-focus Patch
@tiptap/extension-font-family Patch
@tiptap/extension-gapcursor Patch
@tiptap/extension-hard-break Patch
@tiptap/extension-heading Patch
@tiptap/extension-highlight Patch
@tiptap/extension-history Patch
@tiptap/extension-horizontal-rule Patch
@tiptap/extension-image Patch
@tiptap/extension-italic Patch
@tiptap/extension-link Patch
@tiptap/extension-list-item Patch
@tiptap/extension-list-keymap Patch
@tiptap/extension-mention Patch
@tiptap/extension-ordered-list Patch
@tiptap/extension-paragraph Patch
@tiptap/extension-placeholder Patch
@tiptap/extension-strike Patch
@tiptap/extension-subscript Patch
@tiptap/extension-superscript Patch
@tiptap/extension-table-cell Patch
@tiptap/extension-table-header Patch
@tiptap/extension-table-row Patch
@tiptap/extension-table Patch
@tiptap/extension-task-item Patch
@tiptap/extension-task-list Patch
@tiptap/extension-text-align Patch
@tiptap/extension-text-style Patch
@tiptap/extension-text Patch
@tiptap/extension-typography Patch
@tiptap/extension-underline Patch
@tiptap/extension-youtube Patch
@tiptap/html Patch
@tiptap/react Patch
@tiptap/starter-kit Patch
@tiptap/suggestion Patch
@tiptap/vue-2 Patch
@tiptap/vue-3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 8bf5be9
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/66a0967e0852360008631387
😎 Deploy Preview https://deploy-preview-5385--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdbch
Copy link
Member Author

bdbch commented Jul 24, 2024

Looking into the typescript issues

@bdbch bdbch merged commit fe1781f into develop Jul 24, 2024
14 checks passed
@bdbch bdbch deleted the prosemirror-updates branch July 24, 2024 06:01
bdbch added a commit that referenced this pull request Jul 24, 2024
…5385)

* upgrade prosemirror packages to latest versions

* added changeset

* update package-lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants