fix(core): isNodeEmpty no longer considers attributes for it's checks #5393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
This addresses a bug with
isNodeEmpty
where it was also considering attributes on the node for it's emptiness check.Implementation Approach
To address it, I went with a different approach of actually visiting each node to check for emptiness. This is both more performant and will be more accurate since it does not compare other properties like marks & attributes which do not determine emptiness.
Testing Done
I added a bunch of tests to ensure that the implementation not only passes for the previous cases but also considers the different attributes case.
Verification Steps
Additional Notes
Checklist
Related Issues