Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared rollup config #5403

Merged
merged 2 commits into from
Jul 27, 2024
Merged

Shared rollup config #5403

merged 2 commits into from
Jul 27, 2024

Conversation

bdbch
Copy link
Member

@bdbch bdbch commented Jul 27, 2024

This PR adds a singular rollup configuration builder via @tiptap-shared/rollup-config to avoid having to copy it manually to all packages.

@bdbch bdbch requested a review from svenadlung as a code owner July 27, 2024 10:46
Copy link

changeset-bot bot commented Jul 27, 2024

⚠️ No Changeset found

Latest commit: c7c57d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bdbch bdbch merged commit 44e4eca into develop Jul 27, 2024
9 checks passed
@bdbch bdbch deleted the shared-logic branch July 27, 2024 10:46
Copy link

netlify bot commented Jul 27, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit c7c57d9
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/66a4d006749cb90008daf85a
😎 Deploy Preview https://deploy-preview-5403--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bdbch added a commit that referenced this pull request Jul 27, 2024
* add one shared rollup config

* rename to baseConfig
@nperez0111 nperez0111 mentioned this pull request Aug 6, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant