-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jsx): add @tiptap/jsx
for more convenient rendering of Tiptap content
#5558
base: next
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just a quick comment regarding naming and namespaces
What's the status of this one. Going through our approved PRs to see where we can move forward. |
I want to do this for v3, not relative to develop so I haven't worked on it in a minute |
Moved the target branch to next (we'll probably need to sync next with develop soon too) |
Changes Overview
This implements
@tiptap/jsx
which is a package that can render JSX in a node'srenderHTML
method to the format that Tiptap expects.This makes for a more modern experience of describing the content of a Node as you might do in modern frameworks like React/Vue.
Implementation Approach
Here is an example of what this allows for:
Testing Done
Need to add some tests for ensuring that the arrays are all generated correctly. More of a POC than anything.
Verification Steps
Additional Notes
Checklist
Related Issues