-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add support for markviews #5759
base: next
Are you sure you want to change the base?
Conversation
|
❌ Deploy Preview for tiptap-embed failed. Why did it fail? →
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome idea, LGTM!
Tests failed and we'd need to merge with develop again as we got a few merge conflicts. Looking forward to get this merged. |
I want to do this for v3, & I need to make a react markview impl Types have also changed in prosemirror view since |
Should we change the target branch to next then? |
Changes Overview
This adds basic support for Prosemirror markviews to
Mark
s.For this to actually become supported we will need to:
From there, we'd pretty much just support them!
Here is what the API looks like right now, but we will probably add a class to make these elements for you:
Implementation Approach
Pretty much following the same sort of implementation as node views, I was able to add support for markviews.
Testing Done
Verification Steps
I added a temporary markview to a mark and it worked just fine
Additional Notes
Checklist
Related Issues