add defaultType option to horizontal-rule #5877
Open
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nperez0111
reviewed
Nov 29, 2024
| * @default "paragraph" | ||
| * @example "heading" | ||
| */ | ||
| defaultType: string, |
There was a problem hiding this comment.
I like the change, but I feel like defaultType could be more descriptive.
Maybe something like:
- insertAfter
- afterType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
This pull request adds a defaultType option to the horizontal-rule extension, enabling more precise behavior when inserting nodes in a document.
Why This Change Is Necessary
Currently, when a custom
titleextension is defined as the first node of a document (content: "title block+"), inserting ahorizontal-ruleunexpectedly appends atitlenode to the end of the document. This behavior occurs because the default node is inferred from the document schema.By introducing the
defaultTypeoption tohorizontal-rule, we gain control over the default node type (e.g.,paragraph) for insertion scenarios. This ensures predictable behavior, such as avoiding the unintended addition of atitlenode, and makes it easier to manage content structures.