Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing node view props to props type object #6006

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

GYHHAHA
Copy link
Contributor

@GYHHAHA GYHHAHA commented Jan 9, 2025

Changes Overview

I was trying to follow the step from render-a-vue-component section. Everything works except that there was a type error when I pass the customized component to VueNodeViewRenderer. After some searchs, now I think some props are missing. Thus adding them on could be a fix if the absence is not on purpose.

image

Implementation Approach

add 3 missing props declaration to the nodeViewProps object

Testing Done & Verification Steps

error resolved after the change

image

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: 8ba7d4a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit e59762c
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/677f9a5193339200084c1cc3
😎 Deploy Preview https://deploy-preview-6006--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, yea this looks right

@nperez0111 nperez0111 merged commit 9787f8b into ueberdosis:develop Jan 9, 2025
3 of 4 checks passed
@GYHHAHA GYHHAHA deleted the fix-type branch January 9, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants