Improve checks for pkg-config and fall back to gpgme-config #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueno#166 changed from `pkg-config` to `gpgme-config`, but if `PKG_CONFIG_PATH` is not set properly, the C extension library will quietly build without the right linker dependencies. To fix this, we now check for the existence of `gpgme.pc` in `PKG_CONFIG_PATH` and attempt to fall back to `gpgme-config` if it does not exist. Closes ueno#167
ueno
approved these changes
Dec 5, 2022
|
Thanks @ueno! Would you mind tagging 2.0.23 with this? |
|
I'm not sure if this single change qualifies a new release: we had no checks on the existence of |
|
@ueno The issue is that there is a regression in v2.0.22 due to #166. You can install a broken version of The gem is broken: root@160b17998071:/# irb
irb(main):001:0> require 'gpgme'
Traceback (most recent call last):
10: from /usr/bin/irb:23:in `<main>'
9: from /usr/bin/irb:23:in `load'
8: from /usr/lib/ruby/gems/2.7.0/gems/irb-1.2.1/exe/irb:11:in `<top (required)>'
7: from (irb):1
6: from /usr/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:156:in `require'
5: from /usr/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:168:in `rescue in require'
4: from /usr/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:168:in `require'
3: from /var/lib/gems/2.7.0/gems/gpgme-2.0.22/lib/gpgme.rb:3:in `<top (required)>'
2: from /usr/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:92:in `require'
1: from /usr/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:92:in `require'
LoadError (/var/lib/gems/2.7.0/gems/gpgme-2.0.22/lib/gpgme_n.so: undefined symbol: gpgme_data_release - /var/lib/gems/2.7.0/gems/gpgme-2.0.22/lib/gpgme_n.so) |
stanhu
added a commit
to stanhu/ruby-gpgme
that referenced
this pull request
Sep 14, 2023
Cleaning is on by default; it's just that prior to ueno#168 the cleaning was quietly failing: ``` Cleaning files only used during build. /Users/stanhu/.asdf/installs/ruby/3.1.4/lib/ruby/3.1.0/fileutils.rb:637:in `rm_rf': wrong number of arguments (given 2, expected 1) (ArgumentError) from ./extconf.rb:28:in `block in <main>' from <internal:dir>:220:in `glob' from ./extconf.rb:27:in `glob' from ./extconf.rb:27:in `<main>' make: [clean-ports] Error 1 (ignored) ```
ueno
pushed a commit
that referenced
this pull request
Sep 14, 2023
Cleaning is on by default; it's just that prior to #168 the cleaning was quietly failing: ``` Cleaning files only used during build. /Users/stanhu/.asdf/installs/ruby/3.1.4/lib/ruby/3.1.0/fileutils.rb:637:in `rm_rf': wrong number of arguments (given 2, expected 1) (ArgumentError) from ./extconf.rb:28:in `block in <main>' from <internal:dir>:220:in `glob' from ./extconf.rb:27:in `glob' from ./extconf.rb:27:in `<main>' make: [clean-ports] Error 1 (ignored) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#166 changed from
pkg-configtogpgme-config, but ifPKG_CONFIG_PATHis not set properly, the C extension library will quietly build without the right linker dependencies.To fix this, we now check for the existence of
gpgme.pcinPKG_CONFIG_PATHand attempt to fall back togpgme-configif it does not exist.Closes #167