Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PKG_CONFIG_PATH to ensure gpgme builds with local libassuan #190

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

stanhu
Copy link
Collaborator

@stanhu stanhu commented Aug 27, 2024

We had some build failures on macOS with this error:

configure: Use gpgrt-config as libassuan-config
checking for LIBASSUAN - version >= 2.4.2... yes (3.0.1)
checking LIBASSUAN API version... does not match.  want=2 got=3.

This occurs when:

  1. libassuan v3.0 is installed.
  2. PKG_CONFIG_PATH includes the Homebrew path of /opt/homebrew/lib/pkgconfig.

https://github.com/gpg/gpgme/blob/5bf3e6d0754a179b316f90a885371af99bc03ea1/m4/libassuan.m4#L32 attempts to run gpgrt-config libassuan --exists. This will return the Homebrew version of libassuan if PKG_CONFIG_PATH includes it.

To avoid this build failure, preface PKG_CONFIG_PATH with the local versions of libassuan and libgpg-error.

We had some build failures on macOS with this error:

```
configure: Use gpgrt-config as libassuan-config
checking for LIBASSUAN - version >= 2.4.2... yes (3.0.1)
checking LIBASSUAN API version... does not match.  want=2 got=3.
```

This occurs when:

1. libassuan v3.0 is installed.
2. `PKG_CONFIG_PATH` includes the Homebrew path of `/opt/homebrew/lib/pkgconfig`.

https://github.com/gpg/gpgme/blob/5bf3e6d0754a179b316f90a885371af99bc03ea1/m4/libassuan.m4#L32
attempts to run `gpgrt-config libassuan --exists`. This will return
the Homebrew version of libassuan if `PKG_CONFIG_PATH` includes it.

To avoid this build failure, preface `PKG_CONFIG_PATH` with the local
versions of libassuan and libgpg-error.
Copy link
Owner

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ueno ueno merged commit 2681cba into ueno:master Aug 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants