Skip to content

Commit a84468b

Browse files
[extension_google_sign_in_as_googleapis_auth][google_maps_flutter_ios] Manual roll with fixes to example and skipping some native tests (#7571)
It looks like flutter/packages#7521 missed a few packages examples and they are now failing to compile on main. Some native tests have also began to fail consistently for `google_maps_flutter_ios`: flutter/flutter#154641 Some legacy iOS `webview_flutter` tests were also failing: flutter/flutter#154676
1 parent 1f00e3d commit a84468b

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

example/integration_test/legacy/webview_flutter_test.dart

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@ import 'package:webview_flutter_wkwebview_example/legacy/navigation_decision.dar
2222
import 'package:webview_flutter_wkwebview_example/legacy/navigation_request.dart';
2323
import 'package:webview_flutter_wkwebview_example/legacy/web_view.dart';
2424

25+
// TODO(bparrishMines): Remove once https://github.com/flutter/flutter/issues/154676
26+
// is fixed.
27+
const bool skipOnIosFor154676 = true;
28+
2529
Future<void> main() async {
2630
IntegrationTestWidgetsFlutterBinding.ensureInitialized();
2731

@@ -537,7 +541,7 @@ Future<void> main() async {
537541
final String fullScreen =
538542
await controller.runJavascriptReturningResult('isFullScreen();');
539543
expect(fullScreen, _webviewBool(false));
540-
});
544+
}, skip: Platform.isMacOS || skipOnIosFor154676);
541545

542546
testWidgets(
543547
'Video plays full screen when allowsInlineMediaPlayback is false',
@@ -587,7 +591,7 @@ Future<void> main() async {
587591
final String fullScreen =
588592
await controller.runJavascriptReturningResult('isFullScreen();');
589593
expect(fullScreen, _webviewBool(true));
590-
});
594+
}, skip: Platform.isMacOS || skipOnIosFor154676);
591595
},
592596
// allowsInlineMediaPlayback has no effect on macOS.
593597
skip: Platform.isMacOS);

0 commit comments

Comments
 (0)