Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[many] Upgrade example apps to AGP 8.5.2 (if they were below 8.1.0) #7521

Merged
merged 9 commits into from
Aug 29, 2024
Merged

[many] Upgrade example apps to AGP 8.5.2 (if they were below 8.1.0) #7521

merged 9 commits into from
Aug 29, 2024

Conversation

gmackall
Copy link
Member

@gmackall gmackall commented Aug 27, 2024 •
edited
Loading

For flutter/flutter#153795 - specifically the bump to compileSdk 35 requires AGP 8.1.0+ (this isn't documented anywhere, but folks on https://issuetracker.google.com/issues/342522139 are also experiencing it).

Upgrades to AGP 8.5.2 and Gradle 8.7, for example apps that were using AGP less than 8.1.0.

Unblocks framework->packages roller

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gmackall gmackall changed the title Upgrade Gradle and AGP to 8.1.0+ Upgrade example app Gradle and AGP to 8.1.0+ Aug 27, 2024
@gmackall gmackall changed the title Upgrade example app Gradle and AGP to 8.1.0+ Upgrade example apps to AGP 8.5.2 (if they were below 8.1.0) Aug 27, 2024
@gmackall gmackall requested a review from stuartmorgan August 27, 2024 20:52
Piinks
Piinks approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for two_dimensional_scrollables

chunhtai
chunhtai approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@matanlurey
Copy link
Contributor

test-exempt: The example apps are the tests.

@gmackall
Copy link
Member Author

gmackall commented Aug 29, 2024 •
edited
Loading

Overriding the repo checks: The only non-auto-exempted change is a deletion of a gradle wrapper that didn't need to exist.

@gmackall gmackall added autosubmit Merge PR when tree becomes green via auto submit App override: no versioning needed Override the check requiring version bumps for most changes labels Aug 29, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2024
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Aug 29, 2024

auto label is removed for flutter/packages/7521, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2024
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Aug 29, 2024

auto label is removed for flutter/packages/7521, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2024
@gmackall gmackall added autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Aug 29, 2024
@auto-submit auto-submit bot merged commit de42d8e into flutter:main Aug 29, 2024
76 checks passed
@gmackall gmackall mentioned this pull request Aug 29, 2024
Merged
11 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 30, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
de42d8e [many] Upgrade example apps to AGP 8.5.2 (if they were below …
75b62d4 
…8.1.0) (flutter/packages#7521)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
Roll Packages from 2a0f254 to c9c0004 (6 revisions) (#154411)
08c3970 
flutter/packages@2a0f254...c9c0004

2024-08-30 10687576+bparrishMines@users.noreply.github.com [pigeon] Kotlin implementation for ProxyApis  (flutter/packages#6371)
2024-08-29 louisehsu@google.com [in_app_purchase_storekit] Add storekit 2 support for canMakePayments and products (flutter/packages#7473)
2024-08-29 mhvdijk@gmail.com [flutter_adaptive_scaffold] Add correct material spacing and panes (flutter/packages#7428)
2024-08-29 34871572+gmackall@users.noreply.github.com [many] Upgrade example apps to AGP 8.5.2 (if they were below 8.1.0) (flutter/packages#7521)
2024-08-29 tarrinneal@gmail.com [pigeon] allow gen of unused classes (flutter/packages#7529)
2024-08-29 magder@google.com Increase deprecation check minimum to iOS 14 and macOS 13 (flutter/packages#7431)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vasilich6107 pushed a commit to artflutter/flutter that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll @vasilich6107
Roll Packages from 2a0f254 to c9c0004 (6 revisions) (flutter#154411)
e7d7fd7 
flutter/packages@2a0f254...c9c0004

2024-08-30 10687576+bparrishMines@users.noreply.github.com [pigeon] Kotlin implementation for ProxyApis  (flutter/packages#6371)
2024-08-29 louisehsu@google.com [in_app_purchase_storekit] Add storekit 2 support for canMakePayments and products (flutter/packages#7473)
2024-08-29 mhvdijk@gmail.com [flutter_adaptive_scaffold] Add correct material spacing and panes (flutter/packages#7428)
2024-08-29 34871572+gmackall@users.noreply.github.com [many] Upgrade example apps to AGP 8.5.2 (if they were below 8.1.0) (flutter/packages#7521)
2024-08-29 tarrinneal@gmail.com [pigeon] allow gen of unused classes (flutter/packages#7529)
2024-08-29 magder@google.com Increase deprecation check minimum to iOS 14 and macOS 13 (flutter/packages#7431)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@engine-flutter-autoroll @Buchimi
Roll Packages from 2a0f254 to c9c0004 (6 revisions) (flutter#154411)
29fcc71 
flutter/packages@2a0f254...c9c0004

2024-08-30 10687576+bparrishMines@users.noreply.github.com [pigeon] Kotlin implementation for ProxyApis  (flutter/packages#6371)
2024-08-29 louisehsu@google.com [in_app_purchase_storekit] Add storekit 2 support for canMakePayments and products (flutter/packages#7473)
2024-08-29 mhvdijk@gmail.com [flutter_adaptive_scaffold] Add correct material spacing and panes (flutter/packages#7428)
2024-08-29 34871572+gmackall@users.noreply.github.com [many] Upgrade example apps to AGP 8.5.2 (if they were below 8.1.0) (flutter/packages#7521)
2024-08-29 tarrinneal@gmail.com [pigeon] allow gen of unused classes (flutter/packages#7529)
2024-08-29 magder@google.com Increase deprecation check minimum to iOS 14 and macOS 13 (flutter/packages#7431)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot pushed a commit that referenced this pull request Sep 3, 2024
@gmackall
[rfw] Upgrade missed example app (#7545)
e17304d 
`rfw` has multiple example apps - I missed this one in #7521.

Also missed `extension_google_sign_in_as_googleapis_auth` - will need to upgrade that in a follow up PR (it has additional failures after the AGP upgrade, so it isn't a one line fix).
@bparrishMines bparrishMines mentioned this pull request Sep 3, 2024
Merged
11 tasks
auto-submit bot pushed a commit that referenced this pull request Sep 6, 2024
@bparrishMines
[extension_google_sign_in_as_googleapis_auth][google_maps_flutter_ios…
56df73e 
…] Manual roll with fixes to example and skipping some native tests (#7571)

It looks like #7521 missed a few packages examples and they are now failing to compile on main.

Some native tests have also began to fail consistently for `google_maps_flutter_ios`: flutter/flutter#154641

Some legacy iOS `webview_flutter` tests were also failing: flutter/flutter#154676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

@Piinks Piinks Piinks approved these changes

@reidbaker reidbaker reidbaker approved these changes

@matanlurey matanlurey matanlurey approved these changes

@stuartmorgan stuartmorgan Awaiting requested review from stuartmorgan stuartmorgan is a code owner

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

@camsim99 camsim99 Awaiting requested review from camsim99 camsim99 is a code owner

@tarrinneal tarrinneal Awaiting requested review from tarrinneal tarrinneal is a code owner

@Hixie Hixie Awaiting requested review from Hixie Hixie is a code owner

@gspencergoog gspencergoog Awaiting requested review from gspencergoog gspencergoog is a code owner

@domesticmouse domesticmouse Awaiting requested review from domesticmouse domesticmouse is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: camera p: file_selector p: flutter_adaptive_scaffold p: flutter_markdown p: go_router p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: local_auth p: palette_generator p: path_provider p: quick_actions p: rfw Remote Flutter Widgets p: shared_preferences p: url_launcher p: video_player p: webview_flutter platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gmackall @matanlurey @stuartmorgan @reidbaker @Piinks @chunhtai