Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mission timeouts #113

Closed
jpanikulam opened this issue Apr 25, 2016 · 12 comments
Closed

Add mission timeouts #113

jpanikulam opened this issue Apr 25, 2016 · 12 comments
Assignees

Comments

@jpanikulam
Copy link
Member

No description provided.

@jpanikulam jpanikulam self-assigned this Apr 25, 2016
@mattlangford
Copy link
Member

I can include this in my next PR

@jpanikulam
Copy link
Member Author

Perfect

@jpanikulam
Copy link
Member Author

@mattlangford Did we ever land on this?

@mattlangford
Copy link
Member

No reply from @forrestv yet. What do?

@jpanikulam
Copy link
Member Author

Have you tried emailing god-president Trump?

@jpanikulam
Copy link
Member Author

I couldn't find the timeout code on your fork, did you remove it? I was going to clone and try

@mattlangford
Copy link
Member

I did remove it. I can add it back tonight.

@forrestv
Copy link
Member

No reply from @forrestv yet. What do?

Huh? Not sure what you mean. Are you waiting on me fixing the spurious traceback that is printed in the case you emailed me? I thought it wasn't blocking any progress..?

@mattlangford
Copy link
Member

Hmm I guess you're right. It doesn't actually break anything, no reason to fret over it.

@forrestv
Copy link
Member

Well, I'm definitely going to look into it. I just wanted to point out that
it shouldn't prevent you from advancing.

I'm still a bit confused, though: that issue you showed me, I wonder why I
never saw it before when I was writing missions... From the script you
showed me, it didn't look like you were doing anything unusual... I have to
try to replicate it locally.

FYI, also, I'm likely going to redo the txros action API. It's a mess right
now.

On Wed, May 18, 2016 at 9:47 AM, mattlangford notifications@github.com
wrote:

Hmm I guess you're right. It doesn't actually break anything, no reason to
fret over it.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#113 (comment)

@mattlangford
Copy link
Member

@jpanikulam, have you tried running it yet? I wonder if it's just a weird issue on my machine. I haven't ran it anywhere else.

Happy birthday by the way Forrest

@sentree sentree self-assigned this Apr 19, 2017
@kev-the-dev
Copy link
Contributor

Will be done via #320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants