Configure crowdsourcing instructions through UI + add them to config #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oplatek
reviewed
Aug 6, 2024
factgenie/utils.py
Outdated
| instructions_html = markdown.markdown(config["annotator_instructions"]) | ||
| annotator_prompt = config["annotator_prompt"] | ||
| final_message_html = markdown.markdown(config["final_message"]) | ||
| display_overlay = config.get("display_overlay", True) |
There was a problem hiding this comment.
I would suggest to name it is_display_overlay
There was a problem hiding this comment.
I renamed it to has_display_overlay
oplatek
reviewed
Aug 6, 2024
factgenie/utils.py
Outdated
| final_message_html = markdown.markdown(config["final_message"]) | ||
| display_overlay = config.get("display_overlay", True) | ||
|
|
||
| content = content.replace("{ FACTGENIE_PLACEHOLDER: instructions }", instructions_html) |
There was a problem hiding this comment.
This looks like jinja2 should handle that. Just use {{ something|safe }} so it does not escape it.
There was a problem hiding this comment.
I tried that first, but there were also Jinja variables to be filled later and these turned out to be problematic.
But the variable were only in the header and the footer, so I solved it by splitting the template into three parts. I guess it's a bit cleaner now.
oplatek
reviewed
Aug 6, 2024
…ndering the template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically configures the crowdsourcing page based on the instructions entered when creating the campaign.
We include three text segments:
The instructions are saved in the YAML config and in the campaign metadata.
Additionally, we allow the user to configure checkboxes that the user can check for each example.
Resolves #58
Resolves #9
Helps with #18