Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Implements cost plugin #51

Merged
merged 9 commits into from
Apr 30, 2020
Merged

[WIP] Implements cost plugin #51

merged 9 commits into from
Apr 30, 2020

Conversation

javanlacerda
Copy link

No description provided.

DiegoGamaV
DiegoGamaV approved these changes Feb 28, 2020
View reviewed changes
Copy link

@DiegoGamaV DiegoGamaV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds promising! A good idea is to further test the divisor in the error model to check the results.

armstrongmsg
armstrongmsg requested changes Feb 28, 2020
View reviewed changes
monitor/utils/plugin/k8s.py Show resolved Hide resolved
monitor/utils/plugin/k8s.py Outdated Show resolved Hide resolved
monitor/utils/plugin/k8s.py Outdated Show resolved Hide resolved
kubejobs_cost/__init__.py Show resolved Hide resolved
kubejobs_cost/__init__.py Outdated Show resolved Hide resolved
@armstrongmsg armstrongmsg merged commit acea99a into master Apr 30, 2020
@armstrongmsg armstrongmsg deleted the cost_plugin_impl branch April 30, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseims joseims joseims approved these changes

@DiegoGamaV DiegoGamaV DiegoGamaV approved these changes

@armstrongmsg armstrongmsg armstrongmsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@javanlacerda @armstrongmsg @DiegoGamaV @joseims