Skip to content

Commit

Permalink
Merge pull request #536 from ufo-kit/fix-codecov-upload
Browse files Browse the repository at this point in the history
Fix github actions
  • Loading branch information
MarcusZuber authored Apr 18, 2024
2 parents 95eb1a0 + 9ca5b2b commit 80883d7
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,14 @@ jobs:
run: |
coverage run --source=concert -m pytest -m "not skip_ci"
- name: Convert coverage to xml
if: matrix.python-version == '3.8'
if: matrix.python-version == '3.12'
run: |
coverage xml --omit="concert/tests/util/_package/_module.py"
- name: Upload coverage to Codecov
if: matrix.python-version == 3.8
if: matrix.python-version == '3.12'
uses: codecov/codecov-action@v2
with:
fail_ci_if_error: true
fail_ci_if_error: false
files: ./coverage.xml
token: ${{ secrets.CODECOV_TOKEN }}
verbose: true
6 changes: 5 additions & 1 deletion .readthedocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,12 @@ formats:
- pdf

# Optionally set the version of Python and requirements required to build your docs
build:
os: ubuntu-22.04
tools:
python: "3.12"

python:
version: 3.8
install:
- requirements: requirements.txt
- requirements: docs/requirements.txt

3 comments on commit 80883d7

@tfarago
Copy link
Contributor

@tfarago tfarago commented on 80883d7 Jun 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still fails on decentralize on python 3.12, can you check @MarcusZuber please?

@MarcusZuber
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did not work because you did not fully apply these changes in the decetralized branch. I fixed it now also there.

@tfarago
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I guess I messed up the merge conflict here, sorry about that...

Please sign in to comment.