Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imagej #518

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Fix imagej #518

merged 4 commits into from
Jul 19, 2023

Conversation

tfarago
Copy link
Contributor

@tfarago tfarago commented Jul 18, 2023

No description provided.

because then it can't be pickled and the multiprocessing call fails.
Fixes #517.
because it doesn't work out of the box, if needed implement properly
later.
@tfarago tfarago requested a review from MarcusZuber July 18, 2023 11:53
@tfarago tfarago self-assigned this Jul 18, 2023
related to issue #517.
@tfarago
Copy link
Contributor Author

tfarago commented Jul 18, 2023

Why does libtiff installation fail now? Oh man, the setting up of actions breaks more often than the code itself.

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (b3fbd53) 88.36% compared to head (553f72d) 88.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
+ Coverage   88.36%   88.38%   +0.01%     
==========================================
  Files         120      121       +1     
  Lines        8306     8317      +11     
==========================================
+ Hits         7340     7351      +11     
  Misses        966      966              
Impacted Files Coverage Δ
concert/tests/integration/test_ext.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@MarcusZuber MarcusZuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is fixed.

The only thing I don't like so much (but is only slightly related to the process-spawning issue): We write big-tiff, which requires the bioformats-plugin and you then also have to click trough the bioformats-import dialogues for just viewing a single image.

@tfarago
Copy link
Contributor Author

tfarago commented Jul 19, 2023

On my machine I don't have to click anything, hm.

@tfarago tfarago merged commit 5d0da45 into master Jul 19, 2023
5 checks passed
@tfarago tfarago deleted the fix-imagej branch July 19, 2023 08:57
@MarcusZuber
Copy link
Member

It also always a new imagej instance.
When imagej starts it tell you the "imagej instance id", which can be used for opening future images in the same imagej instance.

concert > imagej(img)

concert > Open other images in this ImageJ panel as follows:
  imagej -p 1 <image1> [<image2> ... <imageN>]

@tfarago
Copy link
Contributor Author

tfarago commented Jul 20, 2023

On my machine this also doesn't happen. Update imagej?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants