chore: Enhancement proposals on decentralize branch #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From scipy=1.10.0 onward pooch package has been included as the optional dependency for the datasets module. Upon importing datasets module there's supposed to be no error. However, calling module function will raise an ImportError if pooch is missing from the environment. Ref: scipy/scipy#16854. This is need for tests/util/focous.py which is used in TestProcesses.
Coverage upload issue concerning codecov is fixed in master
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## decentralize #522 +/- ##
===============================================
Coverage ? 78.88%
===============================================
Files ? 126
Lines ? 9371
Branches ? 0
===============================================
Hits ? 7392
Misses ? 1979
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
It does not make sense to refactor the api-layer without being familiar with the big picture of the implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Premise: With this PR we would like to make some enhancement proposals on top of the changes in the decentralize branch. The details of the proposed enhancement would be entered gradually and finalized post discussion.