Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added virtual function uca_camera_grab_live #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gabs1234
Copy link

Nothing special in the implementation. Everything is the same as uca_camera_grab.

Nothing special the implementation. Everything is the
same as `uca_camera_grab`.
Copy link
Contributor

@tfarago tfarago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the duplication good.

@@ -375,6 +375,43 @@ uca_mock_camera_grab (UcaCamera *camera, gpointer data, GError **error)
return TRUE;
}

static gboolean
uca_mock_camera_grab_live (UcaCamera *camera, gpointer data, GError **error)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make one function which is called from both, the normal grab and grab_live instead of duplicating code?

* with uca_camera_grab().
*/
gboolean
uca_camera_grab_live (UcaCamera *camera, gpointer data, GError **error)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants