Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed download links for Mac and Linux #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonana-split
Copy link

@jonana-split jonana-split commented Jun 21, 2024

This change resolves #15

The download links for Mac and Linux have been fixed.

I used the most recent version of the game via the BytesOfLove Repo to generate these links in Ren'Py and uploaded them to Google Drive, where they can now be downloaded.

Windows link was not updated as that was not asked, but I can definitely do that if what I've done here is alright.

@AntonCSalvador
Copy link
Contributor

LGTM, if you can do the Windows link too I think it will be good to merge!

@AntonCSalvador
Copy link
Contributor

@jonana-split ^^

@jonana-split
Copy link
Author

@AntonCSalvador Will do! I'll get to that now. I also noticed that the text color in the About and Help screens is a bit dark in this version of the game. I'm not quite sure how that would be altered but I wanted to let you know!

@AntonCSalvador
Copy link
Contributor

@jonana-split ACTUALLY sorry can we review the other PRs in the actual BOL game first before you make the download links?

@jonana-split
Copy link
Author

jonana-split commented Jun 21, 2024

@AntonCSalvador yeah ofc! just lmk when ur good to go and i can make the links again

@AntonCSalvador
Copy link
Contributor

Thanks for your hard work, it is really appreciated! I'll ping you here when I get the update from our main PR person for the Bytes Of Love main repo

@jonana-split
Copy link
Author

Its no problem at all! Love what you guys are making here :D and okay sounds good!

@jonana-split jonana-split deleted the jm_branch branch June 21, 2024 19:06
@jonana-split jonana-split restored the jm_branch branch June 21, 2024 19:07
@jonana-split jonana-split reopened this Jun 21, 2024
@zeim839
Copy link
Contributor

zeim839 commented Jun 30, 2024

Why use a Google Drive URL? Create a GitHub release and just link users to the releases page. That way, you don't have to update the URL every time the game is updated.

Bytes of Love releases page: https://github.com/ufosc/VisualNovel/releases
GitHub Releases docs: https://docs.github.com/en/repositories/releasing-projects-on-github/about-releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Download Links
3 participants