Updates for new 20231027 orog fixed files

[GeorgeGayno-NOAA]

DESCRIPTION OF CHANGES:

Updates required for the new orography fixed files.

TESTS CONDUCTED:

If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.

• Compile branch on all Tier 1 machines using Intel (Orion, Hercules, Jet, Hera and WCOSS2). Done using 7c74c2c.
• Compile branch on Hera using GNU. Done using 7c74c2c.
• Compile branch in 'Debug' mode on WCOSS2. Done using 7c74c2c.
• Run unit tests locally on any Tier 1 machine. Done on Hera using 7c74c2c.
• Run relevant consistency tests locally on all Tier 1 machine. For this issue, that includes chgres_cube, grid_gen and global_cycle. Done using 7c74c2c. All tests passed as expected.

Describe any additional tests performed (using 7c74c2c):

• On Hera, the gdas_init utility was tested using recent GDAS data and the 'orog' files in the 20231027 directory (several model resolutions were tested).
• On Hera, the sfc_climo_gen utility was tested using global and regional 'orog' files in the 20231027 directory.

DEPENDENCIES:

NOAA-EMC/global-workflow#1981
NOAA-EMC/global-workflow#1984

DOCUMENTATION:

Doxygen compiled with no issues on Hera using 7c74c2c.

ISSUE:

Fixes #867.

[GeorgeGayno-NOAA]

@sanatcumar - your review is welcome.

[KateFriedman-NOAA]

Update looks good! There is an open question about whether we should still have and use the non-mx versions of the oro_data fix files. This update assumes we will use the non-mx versions when ocean resolution is not set. If the decision is made to always use a mx version then a couple scripts in this PR will need updating to remove the non-mx blocks. PR is good otherwise!

[aerorahul]

@GeorgeGayno-NOAA
The changes look good to me. I have similar questions as @KateFriedman-NOAA.

[aerorahul]

changes look good to me. @KateFriedman-NOAA raises excellent questions

[GeorgeGayno-NOAA]

Update looks good! There is an open question about whether we should still have and use the non-mx versions of the oro_data fix files. This update assumes we will use the non-mx versions when ocean resolution is not set. If the decision is made to always use a mx version then a couple scripts in this PR will need updating to remove the non-mx blocks. PR is good otherwise!

Thanks. Will await the official decision about whether to retain or remove the non-mx versions before merging.

[KateFriedman-NOAA]

Will await the official decision about whether to retain or remove the non-mx versions before merging.

@GeorgeGayno-NOAA The non-mx versions have been removed from the new orog/20231027 version. We'll be using the mx versions all the time now. In the workflow we'll use this case block to set OCNRES: https://github.com/NOAA-EMC/global-workflow/blob/develop/parm/config/gfs/config.base.emc.dyn#L169:L189

Not sure how you'd like to handle defining OCNRES in UFS_UTILS.

[GeorgeGayno-NOAA]

Will await the official decision about whether to retain or remove the non-mx versions before merging.

@GeorgeGayno-NOAA The non-mx versions have been removed from the new orog/20231027 version. We'll be using the mx versions all the time now. In the workflow we'll use this case block to set OCNRES: https://github.com/NOAA-EMC/global-workflow/blob/develop/parm/config/gfs/config.base.emc.dyn#L169:L189

Not sure how you'd like to handle defining OCNRES in UFS_UTILS.

For consistency, I can enforce the same combinations of ATM/OCN resolutions in gdas_init. Is that utility called from the workflow? Should I use the same variable name - OCNRES?

[aerorahul]

@GeorgeGayno-NOAA
We don't call gdas_init from the workflow (yet). But that would be great.

[KateFriedman-NOAA]

Should I use the same variable name - OCNRES?

Yes please, for consistency and the future. Thanks @GeorgeGayno-NOAA !

[GeorgeGayno-NOAA]

Should I use the same variable name - OCNRES?

Yes please, for consistency and the future. Thanks @GeorgeGayno-NOAA !

See 7c74c2c.

[KateFriedman-NOAA]

See 7c74c2c.

Looks great, thanks @GeorgeGayno-NOAA !