-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor cloud tunings to improve cloud fraction and radiation in UFS #1
Minor cloud tunings to improve cloud fraction and radiation in UFS #1
Conversation
Fixes NCAR#966 |
@grantfirl , @haiqinli : Hi Grant. Thanks for doing this. Can I make a simple request? About 5 months ago, someone added a new boolean variable to the argument list called My request is simply moving this bool variable down the arg list to precede |
@gthompsnWRF Sure thing, done: 8cfde78. I also added a check for the optional logical variable before it is used to avoid future errors. |
@grantfirl The associated/prior PR had 2 positive reviews - one of which was Ruiyu. Could we get those same reviewers again? |
@ChunxiZhang-NOAA It looks like I don't have permissions in this repo to add reviewers. Can you add @RuiyuSun as a reviewer please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me. Greg and Ruiyu, please review it.
Assumed-shape in gwdps.f
Updates for ufs/dev PR#30
Remove MYNN SFC logic from noahmpdrv.F90 and fix CMakeLists.txt authors
update CODEOWNERS to replace Chunxi with Qingfu
Fix memory error in saturation adjustment code when MULTI_GASES=ON
add Rhae Sung Kim to CODEOWNERS file
Move DDTs to host and fix compilation errors
All credit for code changes and description to @gthompsnWRF
This PR is attempting to increase some cloud ice aloft explicitly in the Thompson microphysics by permitting a larger number of ice crystals (as a maximum) and by overall decreasing the fractional cloudiness in the Thompson cloud fraction scheme (
subroutine cal_cldfra3
). The following list of 4 items describes the changes introduced by this PR:SQRT(SQRT(expression))
in place of a single square root (see graphic below for how that affects the outcome).hnhj
because this author was already credited in a comment block and having initials on many lines is pointless.The first two items listed above are intended to improve explicitly-created clouds by the microphysics whether or not the
icloud = 3
option is attempted. The third item is an attempt to reduce what was seen as too much high-altitude ice cloud causing outgoing longwave radiation to be too low compared to the 240 W/m2 target value.The graphic below represents the cloud fraction diagnosed as a function of relative humidity for a sample condition of approximately 13km horizontal grid spacing and 250m vertical level spacing to arrive at the Critical RH values of 0.82 over land (red) and 0.90 over ocean (blue). Dashed lines are the older diagnosis and solid lines with dots are the outcome of the new code.