MYNN fix for numerical stability issues with mixing snow #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with the LAI monthly climatology that is used in HRRR
joeolson42
requested review from
tanyasmirnova,
grantfirl,
Qingfu-Liu and
dustinswales
as code owners
Qingfu-Liu
approved these changes
May 15, 2023
tanyasmirnova
approved these changes
May 15, 2023
|
@joeolson42 John Michalakes, working with NEPTUNE, came across a Cray compiler error in module_bl_mynn that is an easy fix. Is this critical to be merged as-is, or can I make the small changes and combine them in this PR? |
|
@joeolson42 @michalakes Please see joeolson42#3 to address the issue reported by @michalakes: #72. It looks like one of the offending lines was already fixed in #43, but I fixed the other two. |
|
fixes #72 if joeolson42#3 is merged |
|
They can be combined.
…On Fri, May 19, 2023 at 9:56 AM Grant Firl ***@***.***> wrote:
fixes #72 <#72> if
joeolson42#3 <joeolson42#3> is merged
—
Reply to this email directly, view it on GitHub
<#71 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADLRR3UHWVQABOP6XPWEB7LXG6JZZANCNFSM6AAAAAAYAFXPZI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Joseph Olson
Physics Branch Chief
Environmental Prediction Advancement Division
NOAA-Global Systems Laboratory
Boulder, Colorado
|
Cray compiler fix
…n fraction instead of LAI to define the growing phase of the crops
tanyasmirnova
approved these changes
May 26, 2023
grantfirl
approved these changes
May 30, 2023
dustinswales
approved these changes
May 31, 2023
Merged
36 tasks
tanyasmirnova
approved these changes
Jun 6, 2023
|
All tests are finished on UFS-WM PR #1754. As this PR is approved, @grantfirl could you please go ahead and merge? |
drnimbusrain
pushed a commit
to noaa-oar-arl/ccpp-physics
that referenced
this pull request
Mar 28, 2024
sync with the ufs/dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is simply a removal of the snow mixing, reverting back to the RRFS Base E configuration. For some unknown reason, mixing snow was contributing to numerical instabilities. The ultimate cause of this instability will be investigated in the future but for now, snow mixing is deactivated.
There is also a small change to table values of Leaf Area Index to match them better with the LAI monthly climatology that is used in HRRR.