-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in aerinterp read routines that break 32-bit physics and pass NetCDF errors up through errflg&errmsg #85
Fix bug in aerinterp read routines that break 32-bit physics and pass NetCDF errors up through errflg&errmsg #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
looks good to me. Approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SamuelTrahanNOAA Thanks for these changes.
You didn't actually approve the PR. You just typed the word "Approved." To approve the pull request, you need to submit an approving review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. @SamuelTrahanNOAA, Thanks.
@SamuelTrahanNOAA Please merge in the latest ufs/dev branch in preparation for the merge queue. |
I already did that. Also, I validated against the baseline after merging ufs/dev. |
@SamuelTrahanNOAA Ah, I see that now. Sorry for spamming and thanks for being on top of it. |
Testing is now complete on UFS-WM PR #1797. @SamuelTrahanNOAA @grantfirl as this ccpp-physics sub-component PR is approved, please feel free to merge it. |
sync with ufs/dev
The aerinterp routines use
real*4
arrays to readreal*8
data when compiled with 32-bit physics. This causes a crash because of the NetCDF Fortran 77 interface, which does not know which datatype it has. These changes: