Remove symbolic linking of diag_table when running in ensemble mode. #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBeck-NOAA
requested review from
BenjaminBlake-NOAA,
gsketefian,
JulieSchramm and
mkavulich
as code owners
SamuelTrahanNOAA
pushed a commit
to SamuelTrahanNOAA/regional_workflow
that referenced
this pull request
Sep 15, 2023
…ty#553) * Update regional workflow based on the tests from: 1) RRFS_A v0.6.1 on Cactus 2) summer retro of RRFS determinstic, EnKF DA, ensemble forecast on CONUS 3km on WCOSS2 3) summer retro of EnKF DA on CONUS 3km on Hera * Remove "export FORT_FMT_NO_WRAP_MARGIN=true" on WCOSS2 model forecast. This solved the problem that "-DFASTER=ON" hangs the forcast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
PR #349 (via PR #533) moves diag_table creation from the grid generation step to the run_fcst portion of the workflow. However, it also uses the "run_dir" location instead of "cycle_dir" as the target for the diag_table file. While these two locations are identical for deterministic simulations, they are not the same when using the ensemble mode (due to member directories). Therefore, the diag_table file should no longer be symbolically linked from the "cycle_dir" location to the "run_dir" directory in ensemble mode (the file is now copied directly to "run_dir" for each ensemble member).
TESTS CONDUCTED:
Successfully ran a deterministic and two-member ensemble simulation on Hera.