Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update FV3 and NEMS #20

Closed
DeniseWorthen opened this issue Jan 27, 2020 · 3 comments
Closed

update FV3 and NEMS #20

DeniseWorthen opened this issue Jan 27, 2020 · 3 comments

Comments

@DeniseWorthen
Copy link
Collaborator

FV3 has been committed with the [0-1] limitation on imported ice fraction. NEMS has also been committed to remove ice-ocean merges in prep_atm. ufs-s2s-model should be updated with new baselines.
@rsdunlapiv
Copy link
Collaborator

@DeniseWorthen for the [0-1] limitation do you write out any kind of warning if this is more than roundoff? I could see things going wacky and then this correction masks a bigger problem down the road when we forget about it. So, if a fraction came in as 1.78 or even 1.1, would you still prefer the model to error out and abort?

@DeniseWorthen
Copy link
Collaborator Author

The values we see >1.0 are very small, on the order of 10-15. I did add a write statement in the nems mediator which will flag values >1.0 in the PET log.

@rsdunlapiv
Copy link
Collaborator

I like it. This could save someone weeks of time in the future. ;)

@DeniseWorthen DeniseWorthen mentioned this issue Jan 28, 2020
Merged
JessicaMeixner-NOAA pushed a commit to JessicaMeixner-NOAA/ufs-s2s-model that referenced this issue Apr 23, 2020
@DeniseWorthen
Merge pull request ufs-community#20 from ufs-community/develop
5058920
ShanSunNOAA pushed a commit to ShanSunNOAA/ufs-s2s-model that referenced this issue Oct 28, 2020
@SamuelTrahanNOAA
fix bugs found in pbl and ozone 3d diagnostic tendencies (ufs-commun…
b00cd33 
…ity#20)

PBL tendencies were missing in two schemes; now fixed. Squashed commit of the following:

* fix bugs found in pbl and ozone 3d diagnostic tendencies
* remove debugging prints
* implied shape arrays for five variables
* more block labels in CCPP
* yet more bug fixes in ccpp
* make the logging less wordy
* point to hash 238c84cb3c789056c701b70d3373e640ed4fa599 of ccpp/physics
* point to merged version of FV3, with latest ldiag3d/qdiag3d bug fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rsdunlapiv @DeniseWorthen