update ufs-s2s-model to use updated FV3 and FMS tag 2019.01 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This commit retains the setting of value 'huge' over land for fields set to ocean (dusfc etc) in the physics driver. Is that what we want to do? |
I think it's good to have this until we have land or lake models in the coupled system. Besides it sets "huge" over lake points too besides land. |
|
Bin,
I want to follow up with the tests specified in PR #38, they have been done
and the results are reasonable, correct?
…On Fri, Mar 13, 2020 at 12:01 PM Denise Worthen ***@***.***> wrote:
@junwang-noaa <https://github.com/junwang-noaa>
This commit retains the setting of value 'huge' over land for fields set
to ocean (dusfc etc) in the physics driver. Is that what we want to do?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#56 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TPF75Y4UJ5AYGHY3LDRHJKFVANCNFSM4LHESSJQ>
.
|
|
Jun, The tests mentioned in issue #38 have been done and the results are reasonable. |
junwang-noaa
approved these changes
Mar 13, 2020
DeniseWorthen
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ufs-s2s-model commit to merge Moorthi's ccpp and atm-wave coupling code changes in fv3.
closes #38