Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ufs-s2s-model to use the most recent FV3 and NEMS components #60

Merged
merged 7 commits into from
Mar 22, 2020

Conversation

binli2337
Copy link
Collaborator

Use fv3atm committed on 3/18/2020.
Use NEMS committed on 3/19/2020.

close #59

Copy link
Collaborator

@DeniseWorthen DeniseWorthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the 2012 benchmark case for 35d and compared to a previous saved version. Everything appeared reasonable. However, the compset run did not complete correctly. I received the following after the job completed. At that point, cd'ing back into the directory where I had launched the job showed it had been cleaned out. Only subdirectory NEMS and log were present. I will attempt to recreate and if it reproduces I will create an issue on NEMS.
Screen Shot 2020-03-22 at 2 22 42 PM

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Mar 22, 2020 via email

@JessicaMeixner-NOAA
Copy link
Collaborator

@junwang-noaa I thought you wanted the WW3 regression test before this? I can update to PR #57 that adds the WW3 regression test now (just need to merge the changes to that branch). However, both the WW3 regression test and the benchmark regression test will have changed answers after this PR with the update of fv3atm. Since I saw this PR yesterday, I also prepared another branch that I can do a PR from that will have an updated baseline using this fv3atm, depending on the desired order of commits. Please let me know if I should update PR #57 or close that PR and make a new one that will go in after this PR with the added regression tests.

@binli2337 binli2337 merged commit 888c732 into ufs-community:develop Mar 22, 2020
@binli2337 binli2337 deleted the update2020_04 branch April 16, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ufs-s2s-model to use new fv3atm (committed 3/19/2020)
4 participants