-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Replace manage_externals with Git submodules #1028
base: develop
Are you sure you want to change the base?
[develop] Replace manage_externals with Git submodules #1028
Conversation
…Externals.cfg (and associated modifications)
…s.yaml, as the hpc-stack-mod submodule has been removed
…s.yaml, as the hpc-stack-mod submodule has been removed (and commenting out the changes corrected the failure)
…s-weather-model via git submodule update --init --recursive
…er-model doesn't exist as a submodule
To clone the repository, you can use either:
or, if you didn't use the --recursive option:
|
[submodule "sorc/UFS_UTILS"] | ||
path = sorc/UFS_UTILS | ||
url = https://github.com/ufs-community/UFS_UTILS | ||
branch = develop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichaelLueken, the branch
line may not be necessary, but it would be good to add ignore = dirty
instead to exclude any change in the submodules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the suggestion, @chan-hoo! I will try removing the branch
line and adding ignore = dirty
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this helps: In the UFSWM we keep the branch field. It's useful to know in a PR what submodules are bringing in updates and what branch the developer has those updates in as it's important for developers to make branches different names than develop. Maybe not all submodules use a "develop" branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @BrianCurtis-NOAA! You make a very good point, if users are applying changes to a component, it would be nice to see the fork and branch that they are using for those changes. There is no harm in keeping the branch
line, so I will go ahead and keep it for now.
DESCRIPTION OF CHANGES:
As voted on in the first SRW App CM meeting in 2024, this PR replaces the current manage_externals with Git submodules. This PR will remain in draft form until we are ready to proceed with this update.
Type of change
TESTS CONDUCTED:
DEPENDENCIES:
None
DOCUMENTATION:
Documentation will be updated in this PR before it is opened.
ISSUE:
CHECKLIST