Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Fix get_crontab_contents.py #1142

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

mkavulich
Copy link
Collaborator

DESCRIPTION OF CHANGES:

Fix bug described in issue #1141: get_crontab_contents.py fails when run as a script

Type of change

  • Bug fix (non-breaking change which fixes an issue)

TESTS CONDUCTED:

  • derecho.intel
  • gaea.intel
  • hera.gnu
  • hera.intel
  • hercules.intel
  • jet.intel
    • Ran fundamental tests
    • Ran get_crontab_contents.py stand-alone before and after to confirm the fix.
  • orion.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

None

DOCUMENTATION:

None

ISSUE:

Fixes #1141

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Fix bug described in issue #1141
@MichaelLueken MichaelLueken added the bug Something isn't working label Oct 18, 2024
@MichaelLueken MichaelLueken changed the title Fix get_crontab_contents.py [develop] Fix get_crontab_contents.py Oct 18, 2024
Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkavulich -

Thanks for finding and correcting this issue. I was able to confirm the same problem you noted in issue #1141 and that this update successfully corrects the current failure.

Approving PR now.

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Oct 18, 2024
@MichaelLueken
Copy link
Collaborator

Currently, we are unable to run WE2E tests on Gaea and Derecho. Coverage WE2E tests will be manually run on other machines for Gaea and Derecho.

@RatkoVasic-NOAA
Copy link
Collaborator

@MichaelLueken ufs-wm has just been updated to work on gaea-c5. Once we update SRW to this WM version, we should be able to run it on gaea.

@MichaelLueken
Copy link
Collaborator

@MichaelLueken ufs-wm has just been updated to work on gaea-c5. Once we update SRW to this WM version, we should be able to run it on gaea.

Thanks for the update, @RatkoVasic-NOAA!

@mkavulich
Copy link
Collaborator Author

@MichaelLueken For the record, this portion of code is not used in any WE2E tests (which is why this problem wasn't noticed before) so running the full coverage tests is unnecessary. But I understand the need to be safe.

@MichaelLueken
Copy link
Collaborator

The Gaea coverage WE2E tests were successfully completed on Hercules:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used 
----------------------------------------------------------------------------------------------------
community_20241018132111                                           COMPLETE              29.83
custom_ESGgrid_NewZealand_3km_20241018132111                       COMPLETE             116.74
grid_RRFS_CONUScompact_13km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              52.54
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RAP_20241018132  COMPLETE              53.28
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR_2024101813  COMPLETE              70.32
grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson  COMPLETE             756.70
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024101  COMPLETE              42.33
grid_RRFS_CONUScompact_3km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_20  COMPLETE             983.62
grid_SUBCONUS_Ind_3km_ics_RAP_lbcs_RAP_suite_RRFS_v1beta_plot_202  COMPLETE              18.92
2020_CAPE_20241018132117                                           COMPLETE              48.70
2020_easter_storm_20241018132118                                   COMPLETE              67.19
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE            2240.17

@MichaelLueken
Copy link
Collaborator

Derecho WE2E coverage tests were run on Orion:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used 
----------------------------------------------------------------------------------------------------
custom_ESGgrid_IndianOcean_6km_20241018151903                      COMPLETE              43.28
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_plot_20  COMPLETE             102.22
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024101815190  COMPLETE              81.89
grid_RRFS_CONUScompact_13km_ics_HRRR_lbcs_RAP_suite_HRRR_20241018  COMPLETE              68.04
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              16.75
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024101815191  COMPLETE              47.70
pregen_grid_orog_sfc_climo_20241018151916                          COMPLETE              15.24
specify_template_filenames_20241018151919                          COMPLETE              15.62
2019_hurricane_barry_20241018151920                                COMPLETE              94.65
2019_memorial_day_heat_wave_20241018151922                         COMPLETE              85.86
2020_denver_radiation_inversion_20241018151923                     COMPLETE              99.73
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE             670.98

and the Jet fundamental tests were run:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              11.68
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20241  COMPLETE               9.95
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              32.28
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024101  COMPLETE              52.90
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20241018190  COMPLETE              33.91
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024101819090  COMPLETE              53.28
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE             194.00

All Jenkins WE2E coverage tests successfully passed on Hera GNU, Hera Intel, Hercules, and Orion.

As noted by @mkavulich in #1142 (comment), the modification in this PR aren't tested in the WE2E test suites, so no changes in the WE2E tests were expected.

Moving forward with merging this work now.

@MichaelLueken MichaelLueken merged commit 563dd40 into develop Oct 21, 2024
3 of 5 checks passed
@MichaelLueken MichaelLueken deleted the mkavulich-patch-1 branch October 21, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling get_crontab_contents.py as a script fails
3 participants