-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Fix get_crontab_contents.py
#1142
Conversation
Fix bug described in issue #1141
get_crontab_contents.py
get_crontab_contents.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding and correcting this issue. I was able to confirm the same problem you noted in issue #1141 and that this update successfully corrects the current failure.
Approving PR now.
Currently, we are unable to run WE2E tests on Gaea and Derecho. Coverage WE2E tests will be manually run on other machines for Gaea and Derecho. |
@MichaelLueken ufs-wm has just been updated to work on gaea-c5. Once we update SRW to this WM version, we should be able to run it on gaea. |
Thanks for the update, @RatkoVasic-NOAA! |
@MichaelLueken For the record, this portion of code is not used in any WE2E tests (which is why this problem wasn't noticed before) so running the full coverage tests is unnecessary. But I understand the need to be safe. |
The Gaea coverage WE2E tests were successfully completed on Hercules:
|
Derecho WE2E coverage tests were run on Orion:
and the Jet fundamental tests were run:
All Jenkins WE2E coverage tests successfully passed on Hera GNU, Hera Intel, Hercules, and Orion. As noted by @mkavulich in #1142 (comment), the modification in this PR aren't tested in the WE2E test suites, so no changes in the WE2E tests were expected. Moving forward with merging this work now. |
DESCRIPTION OF CHANGES:
Fix bug described in issue #1141:
get_crontab_contents.py
fails when run as a scriptType of change
TESTS CONDUCTED:
get_crontab_contents.py
stand-alone before and after to confirm the fix.DEPENDENCIES:
None
DOCUMENTATION:
None
ISSUE:
Fixes #1141
CHECKLIST