-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix quoting/escaping in Jenkinsfile #403
Fix quoting/escaping in Jenkinsfile #403
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving fix to quoting/escaping in Jenkinsfile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jessemcfarland - The Jenkins CI is failing with this update:
WorkflowScript: 180: unexpected char: '\' @ line 180, column 111.
xtype posix-extended -regex "^\.\/.*\/(o
^
Please see Jenkins CI pipeline.
4c5109b
to
46cfca5
Compare
@jessemcfarland @danielabdi-noaa Why is the Jenkins CI test pipeline now failing for all of the builds? There should be no difference between the successful runs from last night and this morning to the run currently running in Jenkins for PR #403. Why was PR #378 able to set ${SRW_WE2E_COMPREHENSIVE_TESTS} to false, but PR #403 is unable to resolve this variable? |
@MichaelLueken I believe it is because of a commit made in the morning to test out deleting only the large input/output files of the experiment directory so that we can keep the experiment directory longer and also reduce the upload size to S3. @jessemcfarland was in the process of testing this change and planning to run the fundamental tests on all platforms one more time. It is nothing to worry about because the worst is to undo those commits and everything will be back to normal. |
Looks like Orion run finished successfully so approving. |
I just wanted to ensure I fixed the SRW_WE2E_COMPREHENSIVE_TESTS variable issue with the Orion run. I'm running on all platforms to ensure the |
@jessemcfarland I'll keep my eye on the current Jenkins run. Once it successfully completes, I will approve this PR and merge it. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests have passed in Jenkins, so I approve this update.
DESCRIPTION OF CHANGES:
This PR properly quotes and escapes the line in the Jenkinsfile that removes large data sets from the experiment directory. Currently, the Jenkins pipeline will not execute due to this issue.
Type of change
TESTS CONDUCTED:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR: