Add the RRFS_v1alpha suite to the list of suites to build for #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsketefian
requested review from
JeffBeck-NOAA,
JulieSchramm and
mkavulich
as code owners
JeffBeck-NOAA
approved these changes
Nov 11, 2020
JeffBeck-NOAA
requested changes
Dec 4, 2020
JeffBeck-NOAA
approved these changes
Dec 5, 2020
climbfuji
approved these changes
Dec 5, 2020
1) Add the RRFS_v1alpha suite to the list of suites for which to build the forecast model code. 2) Remove RRFS_v1beta from the list of suites for which the forecast model will be built. We have to do this because RRFS_v1beta is no longer available in the release/public-v2 branch of ufs-weather-model. 3) Update hashes in Externals.cfg to latest versions of release branches (except for regional_workflow, whose latest hash is not known yet; will be known only after the PR for adding RRFS_v1alpha suite to regional_workflow is merged).
gsketefian
force-pushed
the
feature/RRFS_v1alpha
branch
from
ef2c81f to
22e397f
Compare
gsketefian
added a commit
to ufs-community/regional_workflow
that referenced
this pull request
Dec 8, 2020
…sed in the workflow. This entails: (#361) This PR should be merged at the same time as PR #[51](ufs-community/ufs-srweather-app#51) into ufs-srweather-app:release/public-v1 branch. ## DESCRIPTION OF CHANGES: * Add the RRFS_v1alpha suite to the set of valid suites that can be used in the workflow. This entails: * Adding this suite to the list of valid values for CCPP_PHYS_SUITE in ush/valid_param_vals.sh. * Adding this suite to the various if-statements in the ex-scripts for the make_ics and make_lbcs tasks. * Adding a stanza for this suite in ush/templates/FV3.input.yml. * Adding a diag_table for this suite. * Adding a field_table for this suite. Note that the RRFS_v1alpha suite should be identical to RRFS_v1beta except that the MYNN surface layer parameterization is replaced with the GFS one. However, currently in the ufs-weather-model, RRFS_v1alpha differs from RRFS_v1beta not only in the surface parameterization but also in the use of the Noah MP land surface model (instead of the Noah LSM). Eventually, a PR should go into ufs-weather-model (and fv3atm) to set the LSM in RRFS_v1alpha to Noah (without MP). * Add WE2E tests for the RRFS_v1alpha suite. * Change the list of WE2E tests that must be run for the release branch (for testing PRs) to use the RRFS_v1alpha suite instead of RRFS_v1beta. * Remove the RRFS_v1beta suite from the list of valid values for CCPP_PHYS_SUITE in ush/valid_param_vals.sh. This disables the use of RRFS_v1beta in the release branch. This must be done because the RRFS_V1beta suite has been removed from the release/public-v2 branch of ufs-weather-model. * Remove from the yaml configuration file for the FV3 namelist (FV3.input.yml) those suites that are neither in the develop branch nor the release/public-v2 branch of ufs-weather-model (or, really of its fv3atm submodule). These suites are FV3_GSD_SAR_v1 and FV3_RRFS_v0. * Modify the yaml configuration file for the FV3 namelist (FV3.input.yml) so that those suites that use Thompson micorphysics set the variable effr_in to False. Note that we make this change not only for the suites that can be used with the release/public-v1 branch (of regional_workflow) but also the ones that can be sued with the develop branch in order to keep differences between these two branches to a minimum. ## TESTS CONDUCTED: The following WE2E tests were run on Hera: * GST_release_public_v1 * grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 * grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1alpha * grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 * grid_RRFS_CONUS_13km_ics_HRRR_lbcs_RAP_suite_RRFS_v1alpha * grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 * grid_RRFS_CONUS_3km_ics_HRRR_lbcs_RAP_suite_RRFS_v1alpha All were successful. Note that the tests involving RRFS_v1alpha are using the Noah MP LSM. This will be changed in the future (in the fv3atm repo), at which point the tests should be rerun. ## CONTRIBUTORS (optional): @climbfuji @JacobCarley-NOAA
christinaholtNOAA
added a commit
to christinaholtNOAA/ufs-srweather-app
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be merged at the same time as PR #361 into regional_workflow:release/public-v1.
DESCRIPTION OF CHANGES:
TESTS CONDUCTED:
See PR #361.