-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Change file paths to EPIC data locations and add fix_gsi var #674
[develop] Change file paths to EPIC data locations and add fix_gsi var #674
Conversation
…rdSnyder-NOAA/ufs-srweather-app into feature/epic-data-locations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to get any comments or suggesions on how to deal with the old locations specified under "data" section of the machine.yaml file
@natalie-perlin - the paths found under the "data" section are the default locations of the data files for each platform. Setting this variable to true: I did change the two "data" paths that were pointing to older locations to our EPIC ones. I don't think any further modifications are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EdwardSnyder-NOAA - thank you for taking care of the new FIXgsi data on the platforms!
@EdwardSnyder-NOAA FYI In my PR #683 I added new data on Hera. Details:
So these need to be copied over to the EPIC locations and the variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EdwardSnyder-NOAA These changes look good to me! I will go ahead and approve these changes now, but as @gsketefian noted, please make sure that the new data on Hera has been added to the EPIC maintained data locations.
@gsketefian & @MichaelLueken - I've updated the data in our EPIC data locations as described in Gerard's comment and updated the jinja logic in the hera.yaml. |
@EdwardSnyder-NOAA Your change looks good to me. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@EdwardSnyder-NOAA I have manually reviewed the logs in the Jenkins workspaces on the various machines to make sure that all tests successfully passed (since Jenkins is currently down due to migration to a new site). All Jenkins tests have passed. Since you have the necessary approvals, I will go ahead and merge this work now. I have also removed your issue #672 from being closed, as it looks like you will need to add supported grids for RRFS. Thanks! |
DESCRIPTION OF CHANGES:
Updated the data file paths to point from SRW account locations to EPIC role account locations, so that EPIC can have better control and management of the SRW App data files.
Also added the FIXgsi var.
Type of change
TESTS CONDUCTED:
nco_grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
grid_SUBCONUS_Ind_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
community_ensemble_2mems
grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v16
grid_RRFS_CONUScompact_13km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta
grid_RRFS_CONUScompact_13km_ics_HRRR_lbcs_RAP_suite_HRRR
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_HRRR
MET_verification
DEPENDENCIES:
DOCUMENTATION:
Updated RunSRW and ContainerQuickstart rst files. The files listed paths to the older location and have been updated to point to the EPIC location.
ISSUE:
This PR addresses the lack of FIXgsi directory in the develop branch as described in issue #672
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):
@natalie-perlin for her help moving data, documenting, and testing the changes.