Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build system so that CMAKE_<COMPILER>_FLAGS set at top level will be used by subcomponents #2050

Closed
mark-a-potts opened this issue Dec 18, 2023 · 1 comment · Fixed by #2013
Closed

Fix build system so that CMAKE_<COMPILER>_FLAGS set at top level will be used by subcomponents #2050

mark-a-potts opened this issue Dec 18, 2023 · 1 comment · Fixed by #2013
Assignees
@mark-a-potts
Labels
enhancement New feature or request

Comments

@mark-a-potts
Copy link
Contributor

mark-a-potts commented Dec 18, 2023 •
edited
Loading

Description

CMEPS, CDEPS, CICE, and MOM6 do not inherit CMAKE__FLAGS from the top level build and there is no way to specify new flags like "-fPIC" when linking to other applications like JEDI>

Solution

Change CMakeLists.txt files to inherit flags from top level

Alternatives

The "-fPIC" flag could be added to each CMakeLists.txt file directly, but that would not allow for any flexibility
@mark-a-potts mark-a-potts added the enhancement New feature or request label Dec 18, 2023
@mark-a-potts mark-a-potts self-assigned this Dec 18, 2023
@DeniseWorthen
Copy link
Collaborator

Please fill out the requested information for this issue.

@mark-a-potts mark-a-potts mentioned this issue Dec 18, 2023
Closed
41 tasks
@jkbk2004 jkbk2004 mentioned this issue Jan 4, 2024
Merged
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mark-a-potts mark-a-potts

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@mark-a-potts @DeniseWorthen