Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spack-stack 1.5.1, ESMF 8.5.0, FMS 2023.02.01 + Remove Gaea C4 + Fix build system to allow CMAKE_<COMPILER>_FLAGS to be specified for submodules #2052 #2013

Merged
merged 49 commits into from
Jan 8, 2024
Merged

Spack-stack 1.5.1, ESMF 8.5.0, FMS 2023.02.01 + Remove Gaea C4 + Fix build system to allow CMAKE_<COMPILER>_FLAGS to be specified for submodules #2052 #2013

merged 49 commits into from
Jan 8, 2024

Conversation

FernandoAndrade-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA FernandoAndrade-NOAA commented Nov 29, 2023 •
edited by zach1221
Loading

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.

  • I am confirming reviews are completed in ALL sub-component PR's.

  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:

  • I have added the list of all failed regression tests to "Anticipated changes" section.

  • I have filled out all sections of the template.

Description

This PR updates modulefiles to spack-stack 1.5.1. Updates have been made to the esmf, fms, mapl, and gftl-shared versions within ufs_common.lua. This also includes a fix for Gaea's timeout with cpld_bmark_p8 noted in #1978.

Commit Message

  • Update to spack-stack 1.5.1 along with updates to fms/2023.02.01, esmf/8.5.0, mapl/2.40.3-esmf-8.5.0, gftl-shared/1.6.1, and Hercules gcc/12.2.0
  • Gaea C4 has been removed
  • Hercules/Gnu cases turned off: Cpld_control_p8_gnu, Cpld_control_nowave_noaero_p8_gnu, Cpld_debug_p8_gnu, Cpld_control_pdlib_p8_gnu, Cpld_debug_pdlib_p8_gnu, Datm_cdeps_control_cfsr_gnu
  • Allow CMAKE__FLAGS to be passed to sub-components for use with JEDI

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Subcomponent Pull Requests

Blocking Dependencies

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
Tests effected by changes in this PR:

Intel:
regional_noquilt
control_csawmg
control_csawmgt
control_ras
control_CubedSphereGrid_debug
control_wrtGauss_netcdf_parallel_debug
control_stochy_debug
control_landp_debug
control_csawmg_debug
control_csawmgt_debug
control_ras_debug
control_diag_debug
rap_control_debug
hrrr_control_debug
hrrr_gf_debug
hrrr_c3_debug
rap_unified_drag_suite_debug
rap_diag_debug
rap_cires_ugwp_debug
rap_unified_ugwp_debug
rap_lndp_debug
rap_progcld_thompson_debug
rap_noah_debug
rap_sfcdiff_debug
rap_noah_sfcdiff_cires_ugwp_debug
rrfs_v1beta_debug
rap_clm_lake_debug
rap_flake_debug
gnv1_c96_no_nest_debug
control_wam_debug
rap_control_dyn64_phy32

Hercules/gnu:
control_c48_gnu
control_stochy_gnu
control_ras_gnu
control_flake_gnu
rap_control_gnu
rap_decomp_gnu
rap_2threads_gnu
rap_sfcdiff_gnu
rap_sfcdiff_decomp_gnu
hrrr_control_gnu
hrrr_control_noqr_gnu
hrrr_control_2threads_gnu
hrrr_control_decomp_gnu
rrfs_v1beta_gnu
rap_control_dyn32_phy32_gnu
hrrr_control_dyn32_phy32_gnu
rap_2threads_dyn32_phy32_gnu
hrrr_control_2threads_dyn32_phy32_gnu
hrrr_control_decomp_dyn32_phy32_gnu
conus13km_control_gnu
rap_control_dyn64_phy32_gnu

cpld_control_p8_gnu
cpld_control_nowave_noaero_p8_gnu
cpld_debug_p8_gnu
cpld_control_pdlib_p8_gnu
cpld_debug_pdlib_p8_gnu
datm_cdeps_control_cfsr_gnu

Libraries

Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@FernandoAndrade-NOAA
Copy link
Collaborator Author

Preliminary test with cpld_control_p8 intel/gnu passed with no changes. Running full RTs on Hera. Jet will be added once maintenance finishes to confirm 1.5.1 path.

@FernandoAndrade-NOAA
Copy link
Collaborator Author

It seems Gaea and hercules/gnu tests failed due to esmf 8.5.0 being unavailable. @ulmononian @climbfuji @natalie-perlin FYI. There were cmake and nccmp version conflicts as well.

climbfuji
climbfuji previously requested changes Nov 30, 2023
View reviewed changes
modulefiles/ufs_hercules.gnu.lua Outdated Show resolved Hide resolved
@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Dec 4, 2023 •
edited
Loading

@FernandoAndrade-NOAA May I ask the EPIC team to install fms/2023.02.01 in this spack-stack 1.5.1 package, instead of fms/2023.03? The fms/2023.03 does not have the diag_table bug fix that is in fms/2023.02.01. The GFSv17 requires that bug fix for their application with IAU. We may have to turn off the failed gnu tests on Derocho as specified in JCSDA/spack-stack#860.
@jkbk2004 @climbfuji @laurenchilutti FYI.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Dec 4, 2023

@FernandoAndrade-NOAA May I ask the EPIC team to install fms/2023.02.01 in this spack-stack 1.5.1 package, instead of fms/2023.03? The fms/2023.03 does not have the diag_table bug fix that is in fms/2023.02.01. The GFSv17 requires that bug fix for their application with IAU. We may have to turn off the failed gnu tests on Derocho as specified in JCSDA/spack-stack#860. @jkbk2004 @climbfuji @laurenchilutti FYI.

@RatkoVasic-NOAA @ulmononian FYI: need to move to fms-2023.02-01

@RatkoVasic-NOAA
Copy link
Collaborator

Yes, these are available under 1.5.1:
fms/2023.01 fms/2023.02.01 fms/2023.03

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Dec 6, 2023

@AlexanderRichert-NOAA @Hang-Lei-NOAA can you check status of these library updates on wcoss2/acorn: fms/esmf/mapl/gftl-shared ?

@Hang-Lei-NOAA
Copy link

Hang-Lei-NOAA commented Dec 6, 2023 via email

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Dec 6, 2023 •
edited
Loading

@jong Kim - NOAA Affiliate @.> These libs had been del;ivered to GDIT for installation. Some have been available on wcoss2.
…
On Wed, Dec 6, 2023 at 10:14 AM JONG KIM @.> wrote: @AlexanderRichert-NOAA https://github.com/AlexanderRichert-NOAA @Hang-Lei-NOAA https://github.com/Hang-Lei-NOAA can you check status of these library updates on wcoss2/acorn: fms/esmf/mapl/gftl-shared ? — Reply to this email directly, view it on GitHub <#2013 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKWSMFA3ILJ4UDJBUR2ZKHLYICDT7AVCNFSM6AAAAAA76V2PL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBTGA4DQMRZGU . You are receiving this because you were mentioned.Message ID: @.***>

@Hang-Lei-NOAA If some of them available, we may update the module path in this pr. Can you check and point to installation path? @BrianCurtis-NOAA FYI

@Hang-Lei-NOAA
Copy link

Hang-Lei-NOAA commented Dec 6, 2023 via email

@FernandoAndrade-NOAA
Copy link
Collaborator Author

FernandoAndrade-NOAA commented Dec 6, 2023 •
edited
Loading

Just leaving a note, preliminary testing with control_p8 intel / gnu across Hera, Gaea C5, Jet, Orion, and Hercules succeeded.

@Hang-Lei-NOAA
Copy link

Hang-Lei-NOAA commented Dec 6, 2023 via email

@BrianCurtis-NOAA
Copy link
Collaborator

OK Thanks. I have no idea why they are adding a letter to the library names

@junwang-noaa
Copy link
Collaborator

@FernandoAndrade-NOAA @BrianCurtis-NOAA May I ask if there is any issue with this PR? Is it ready for commit? This feature is requested for several projects. Thanks

@BrianCurtis-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA @BrianCurtis-NOAA May I ask if there is any issue with this PR? Is it ready for commit? This feature is requested for several projects. Thanks

@junwang-noaa Let me run the full suite on WCOSS2 after I finish the testing for Denise's PR 2010. I have to double check I have all of th "-B" packages setup in the modulefile for WCOSS2. Last time I tried it failed but I think I was missing some of the "-B" packages

@FernandoAndrade-NOAA
Copy link
Collaborator Author

@FernandoAndrade-NOAA @BrianCurtis-NOAA May I ask if there is any issue with this PR? Is it ready for commit? This feature is requested for several projects. Thanks

The last set of changes from my side consist of removing Gaea C4 now that C5 is supported. I will also need to rerun Hera RTs to double check the changed results with the switch of FMS from 2023.03 back to 2023.02.01.

@DavidHuber-NOAA DavidHuber-NOAA mentioned this pull request Jan 5, 2024
Open
@zach1221
Copy link
Collaborator

zach1221 commented Jan 5, 2024

Ok, looks like we're ready to begin merge process.

@junwang-noaa
Copy link
Collaborator

@BrianCurtis-NOAA @FernandoAndrade-NOAA I do not see spack-stack version change in Acorn module file, which is still 1.5.0 in the branch. I assume we have spack-stack ready there too (@AlexanderRichert-NOAA, please confirm).

jkbk2004
jkbk2004 previously approved these changes Jan 8, 2024
View reviewed changes
@BrianCurtis-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA @FernandoAndrade-NOAA I do not see spack-stack version change in Acorn module file, which is still 1.5.0 in the branch. I assume we have spack-stack ready there too (@AlexanderRichert-NOAA, please confirm).

I actually ran the tests using 1.5.1 . Forgot to add it to my commit before. Thanks for catching it!

@BrianCurtis-NOAA BrianCurtis-NOAA requested review from climbfuji and removed request for climbfuji January 8, 2024 16:16
@junwang-noaa junwang-noaa dismissed climbfuji’s stale review January 8, 2024 16:54

Dom is on vacation

@jkbk2004 jkbk2004 merged commit 1cab8b7 into ufs-community:develop Jan 8, 2024
@jkbk2004 jkbk2004 mentioned this pull request Jan 8, 2024
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeniseWorthen DeniseWorthen DeniseWorthen left review comments

@hu5970 hu5970 hu5970 left review comments

@zach1221 zach1221 zach1221 approved these changes

@BrianCurtis-NOAA BrianCurtis-NOAA BrianCurtis-NOAA approved these changes

@jkbk2004 jkbk2004 jkbk2004 approved these changes

@RatkoVasic-NOAA RatkoVasic-NOAA RatkoVasic-NOAA approved these changes

@climbfuji climbfuji Awaiting requested review from climbfuji

Assignees

@RatkoVasic-NOAA RatkoVasic-NOAA

Labels
Baseline Updates Current baselines will be updated. jenkins-ci Jenkins CI: ORT build/test on docker container Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Milestone
No milestone