Inconsistent 'calendar' parameter used in model_configure templates

[DusanJovic-NOAA]

Various model_configure templates in tests/parm directory are setting calendar parameter to 'julian' while other are not (commented out):

esg_HAFS_v0_hwrf-model_configure.IN:calendar:                'julian'
model_configure_hafs_shared.IN:calendar:                'julian'
model_configure_hafs.IN:calendar:                'julian'
cpt.nml.IN:#       calendar = 'julian'
wam.nml.IN:#       calendar = 'julian'
model_configure_regional.IN:calendar:                'julian'
csawmg3shoc127.nml.IN:#       calendar = 'julian'
model_configure_fhout.IN:calendar:                'julian'
csawmgshoc.nml.IN:#       calendar = 'julian'
gsd_sar-model_configure.IN:calendar:                'julian'
stretched-nest-quilt-model_configure.IN:calendar:                'julian'
datm_cdeps_configure.IN:calendar:                'julian'
model_configure.IN:calendar:                'julian'

The default value is 'gregorian' (set in fv3_cap.F90) which is consistent with the default calendar set during ESMF initialization (see main program). Why are we using Julian calendar?

[junwang-noaa]

@DusanJovic-NOAA I think this is because the UFS is using GFS physics, in which the physics schemes such as radiation and land surface schemes are using Julian date. Unless we can use the 'Gregorian' date there, we have to use 'Julian' date for consistency.

[DusanJovic-NOAA]

@DusanJovic-NOAA I think this is because the UFS is using GFS physics, in which the physics schemes such as radiation and land surface schemes are using Julian date. Unless we can use the 'Gregorian' date there, we have to use 'Julian' date for consistency.

Julian day and Julian calendar are different things. If physics schemes are using Julian calendar (which I doubt) they are incorrect and should be using Gregorian calendar.

[DusanJovic-NOAA]

I think we should remove:
calendar: 'julian'
from all model_configure files a just set 'gregorian' as a default.

[climbfuji]

We don’t use Julian calendar, that would be a mess. @DusanJovic-NOAA is right, we (Noah MP amongst others) use Julian day, which corresponds to counting the number of days since the beginning of the year.

…

On Mar 18, 2022, at 2:47 PM, Dusan Jovic ***@***.***> wrote: @DusanJovic-NOAA <https://github.com/DusanJovic-NOAA> I think this is because the UFS is using GFS physics, in which the physics schemes such as radiation and land surface schemes are using Julian date. Unless we can use the 'Gregorian' date there, we have to use 'Julian' date for consistency. Julian day and Julian calendar are different things. If physics schemes are using Julian calendar (which I doubt) they are incorrect and should be using Gregorian calendar. — Reply to this email directly, view it on GitHub <#942 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RNGC4F46DUOYH7TVRTVATTWJANCNFSM5JIHA3QA>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.

[junwang-noaa]

Thanks for the clarification. Do we want to get the physics developers to clear this up before we remove the "Julian" as the calendar option? On Fri, Mar 18, 2022 at 4:53 PM Dom Heinzeller ***@***.***> wrote:

…

We don’t use Julian calendar, that would be a mess. @DusanJovic-NOAA is right, we (Noah MP amongst others) use Julian day, which corresponds to counting the number of days since the beginning of the year. > On Mar 18, 2022, at 2:47 PM, Dusan Jovic ***@***.***> wrote: > > > @DusanJovic-NOAA <https://github.com/DusanJovic-NOAA> I think this is because the UFS is using GFS physics, in which the physics schemes such as radiation and land surface schemes are using Julian date. Unless we can use the 'Gregorian' date there, we have to use 'Julian' date for consistency. > > Julian day and Julian calendar are different things. If physics schemes are using Julian calendar (which I doubt) they are incorrect and should be using Gregorian calendar. > > — > Reply to this email directly, view it on GitHub < #942 (comment)>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AB5C2RNGC4F46DUOYH7TVRTVATTWJANCNFSM5JIHA3QA >. > Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > You are receiving this because you are subscribed to this thread. > — Reply to this email directly, view it on GitHub <#942 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI7D6TJFQFYC4UT62EMHTODVATUMTANCNFSM5JIHA3QA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.Message ID: ***@***.***>

[climbfuji]

I don’t understand, what do you want to clear up? Julian days can be used independently of the calendar, and there is no need to remove them.

…

On Mar 18, 2022, at 3:06 PM, Jun Wang ***@***.***> wrote: Thanks for the clarification. Do we want to get the physics developers to clear this up before we remove the "Julian" as the calendar option? On Fri, Mar 18, 2022 at 4:53 PM Dom Heinzeller ***@***.***> wrote: > We don’t use Julian calendar, that would be a mess. @DusanJovic-NOAA is > right, we (Noah MP amongst others) use Julian day, which corresponds to > counting the number of days since the beginning of the year. > > > On Mar 18, 2022, at 2:47 PM, Dusan Jovic ***@***.***> wrote: > > > > > > @DusanJovic-NOAA <https://github.com/DusanJovic-NOAA> I think this is > because the UFS is using GFS physics, in which the physics schemes such as > radiation and land surface schemes are using Julian date. Unless we can use > the 'Gregorian' date there, we have to use 'Julian' date for consistency. > > > > Julian day and Julian calendar are different things. If physics schemes > are using Julian calendar (which I doubt) they are incorrect and should be > using Gregorian calendar. > > > > — > > Reply to this email directly, view it on GitHub < > #942 (comment)>, > or unsubscribe < > https://github.com/notifications/unsubscribe-auth/AB5C2RNGC4F46DUOYH7TVRTVATTWJANCNFSM5JIHA3QA > >. > > Triage notifications on the go with GitHub Mobile for iOS < > https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android < > https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > > You are receiving this because you are subscribed to this thread. > > > > — > Reply to this email directly, view it on GitHub > <#942 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AI7D6TJFQFYC4UT62EMHTODVATUMTANCNFSM5JIHA3QA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > You are receiving this because you commented.Message ID: > ***@***.***> > — Reply to this email directly, view it on GitHub <#942 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RL6CIF4KZZBCQRLSDDVATV37ANCNFSM5JIHA3QA>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.

[yangfanglin]

Julian days are used in astronomical / radiation calculations in the current physics.

[junwang-noaa]

@climbfuji Sorry, what I mean is to remove the following line as Dusan suggested:

calendar: 'julian'

[climbfuji]

I think that can be done anytime, the physics don’t care.

…

On Mar 22, 2022, at 7:03 PM, Jun Wang ***@***.***> wrote: @climbfuji <https://github.com/climbfuji> Sorry, what I mean is to remove the following line as Dusan suggested: calendar: 'julian' — Reply to this email directly, view it on GitHub <#942 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RIRCW4K3FRAG7E74CDVBJUW3ANCNFSM5JIHA3QA>. You are receiving this because you were mentioned.

[DusanJovic-NOAA]

Are we ever going to use calendar that is not Gregorian? If not, then I suggest that we remove the code that reads this option from configure file. Also all history files have two attributes specifying calendar:

        double time(time) ;
                time:calendar = "JULIAN" ;
                time:calendar_type = "JULIAN" ;

which is redundant. One is enough. We can leave calendar and remove calendar_type, or simply remove both.

[junwang-noaa]

The PR was committed, the issue will be closed.

[junwang-noaa]

The PR was committed, the issue will be closed.

[DusanJovic-NOAA]

This was not resolved in #1265

#1265 (comment)

[junwang-noaa]

Thanks, we may need to update the code to write out consistent calendar type in the restart files.

[DusanJovic-NOAA]

Consistent calendar type will be written out in the restart files. But because the restart files (coupler.res) in the baselines have 'incorrect' calendar type we need updated input data.

[junwang-noaa]

I see, maybe we need to update the input data directory then.

[DeniseWorthen]

Need update input data which is used for warm start tests (gdas, gdas-wave).