Update s4 support #1235
Closed
Update s4 support #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intel2022: update Cheyenne hpc-stack locations
|
@DavidHuber-NOAA It will be practical to combine this PR to #1239. Could you make a PR to Dusan's #1239? so that we can merge together. |
|
@jkbk2004 Yes, I will do that now. |
tests/default_vars.sh
Outdated
|
|
||
| TASKS_cpl_atmw_gdas=560; TPN_cpl_atmw_gdas=16; INPES_cpl_atmw_gdas=6; JNPES_cpl_atmw_gdas=8 | ||
| THRD_cpl_atmw_gdas=2; WPG_cpl_atmw_gdas=24; APB_cpl_atmw_gdas="0 311"; WPB_cpl_atmw_gdas="312 559" | ||
| TASKS_cpl_atmw_gdas=544; THRD_cpl_atmw_gdas=2 |
There was a problem hiding this comment.
I think this should be 560, not 544: TASKS_cpl_atmw_gdas=560
There was a problem hiding this comment.
Thanks for the catch @DeniseWorthen. I'll change it and give that test a go.
There was a problem hiding this comment.
Fixed. The control_c384gdas_wav test passes regression testing.
DusanJovic-NOAA
pushed a commit
to DusanJovic-NOAA/ufs-weather-model
that referenced
this pull request
Jun 3, 2022
* update intel compiler to intel2022 * update libpng * update intel compiler on ufs_hera.intel_debug * remove I_MPI_DAPL_UD fot Intel 2022/2021 * update libraries g2 (3.4.5), Jasper (2.0.25), PIO (2.5.3), libpng (1.6.37) * updated gnu/cheyenne hpc-stack location * Update ufs_cheyenne.gnu_debug * Update ufs_cheyenne.intel * Update ufs_cheyenne.intel_debug * Updated S4 RT resource allotments ufs-community#1223 * Updated S4 compiler versions ufs-community#1223 * Corrected cpl_atmw_gdas test task count for S4 ufs-community#1235 ufs-community#1223 Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> Co-authored-by: JONG KIM <jong.kim@noaa.gov> Co-authored-by: Jun Wang <37633869+junwang-noaa@users.noreply.github.com>
|
The PR was merged in #1239. The PR will be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
N/A Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
N/A New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
This updates the core counts and geometries for regression testing on S4. It also updates the S4 module files to use the Intel 2022.1 compilers and the associated hpc-stack libraries..
Issue(s) addressed
Fixes #1223
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
N/A