-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CICE6 to allow WW3-CICE6 coupling; add a cdeps test using C-grid for sea ice dynamics (was #1390) #1381
Update CICE6 to allow WW3-CICE6 coupling; add a cdeps test using C-grid for sea ice dynamics (was #1390) #1381
Conversation
* cesm_ponds is deprecated so remove from ice_in
* all baselines are b4b except cpld_control_ciceC_p8, which runs to completion with changed answers
@DeniseWorthen please bring these up to date with respective authoritative repositories
|
* turn ice coupling off for all hafs+wav tests * turn current coupling off for hafs-atm-wav test
@DeniseWorthen @BrianCurtis-NOAA I will start creating new BL from hera. |
@jkbk2004 The BL date has not been updated. |
@jkbk2004 I don't think the jobs on hera had picked up yet before I removed the labels. |
@DeniseWorthen Thanks for catching it! |
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
Automated RT Failure Notification |
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@DeniseWorthen all tests are done ok. We can move on to merge. |
Ready for approvals and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hash is good.
Follows pdlib and ufs-community#1381, in particular. For WW3, neither mod_def nor WW3/model/bin/switch_meshcap_pdlib_IC4 are here.
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsibility to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
Adds the required field exchanges within the NUOPC cap to couple WW3 and CICE6. This allows eventual implementation of wave-ice coupling developed by CESM in UWM.
To test w/in UWM, additional changes are required:
the meshcap needs an update (meshcap update NOAA-EMC/WW3#757)
a new mesh cap switch file with
IC4
needs to be added. Either the nml or inp file needs to specify ice parameters 1,5 as "C" and EF needs to be an output variable&OUTS E3D = 1, USSP = 1, IUSSP = 3, STK_WN = 0.04, 0.110, 0.3305 /
a new
mod_def
file with&SIC4 IC4METHOD = 8
needs to be created and added to the input directorythe following variables need to be added to
ice_in
wav_coupling_to_cice = true
needs to be added to nems.configure (in ALLCOMP_attributes)Issue(s) addressed
Testing
The additional files and settings described above were added to a sandbox on Cheyenne. The
cpld_debug_noaero_p8
test was run for both Intel and GNU with mediator history files for ICE and WAV enabled. Both jobs ran to completion and the exchanged fields (Si_thick
,Si_floediam
,Sw_elevation_spectrum
) appeared reasonable.A 10d simulation using the
cpld_control_noaero_p8
RT was also run, comparing the wave-ice solution against develop. The ice concentration and thickness changes are in-line w/ intuition that wave-ice interactions will impact marginal ice-zone thermodynamics, with enhanced breakup leading to increased lateral melt. Shown are ice concentration and thickness differences which arise from including wave-ice coupling.Both Hera.Intel and Hera.GNU were run at 17f1605 and all tests except for
cpld_control_ciceC_p8
reproduced. The change in the ciceC test is due to a change in thevisc_method
default toavg_zeta
brought in with the update to Consortium/main. A test was run for this test retaining thevisc_method
asavg_strength
and the develop-20220805 baseline for this test reproduced.After adding the fix for the HAFS wav configurations 83edc46, the
hafs_regional_atm_ocn_wav
andhafs_regional_atm_wav
tests will also change baseliens.Dependencies