clean up additional deprecated control dependencies

[jkbk2004]

PR Checklist

• This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

• This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

• An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
  are specified below.

• Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

• New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsibility to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

• fixes three tests fail due to missing control & control_debug #1524

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

• hera.intel
• hera.gnu
• orion.intel
• cheyenne.intel
• cheyenne.gnu
• gaea.intel
• jet.intel
• wcoss2.intel
• acorn.intel
• opnReqTest for newly added/changed feature
• CI

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

• waiting on noaa-emc/nems/pull/<pr_number>
• waiting on noaa-emc/fv3atm/pull/<pr_number>

[jkbk2004]

RegressionTests_hera.intel.log

[BrianCurtis-NOAA]

@jkbk2004 confirmed he tested rt with -c and -m. Approved

[junwang-noaa]

@jkbk2004 I'd suggest changing these three tests to control_p8 based tests. Since these tests were removed, please add three corresponding tests based on control_p8 to maintain the capabilities. Thanks

[jkbk2004]

@jkbk2004 I'd suggest changing these three tests to control_p8 based tests. Since these tests were removed, please add three corresponding tests based on control_p8 to maintain the capabilities. Thanks

Sure!

[SamuelTrahanNOAA]

There are a lot of important "safeguard" tests that were removed along with the "control" test. Any variants that "control" or "control_debug" had, the "control_p8" should have too.

[DeniseWorthen]

@junwang-noaa

Don't we have control_p8 versions already?

RUN     | control_p8                                                                                                              |                                         | fv3 |
RUN     | control_p8_lndp                                                                                                         |                                         | fv3 |
RUN     | control_restart_p8                                                                                                      |                                         |     | control_p8
RUN     | control_decomp_p8                                                                                                       |                                         |     |
RUN     | control_2threads_p8                   

and also for control_debug_p8?

EDIT: I just re-read what you wrote; I had misunderstood so you can disregard this comment.